Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MembershipChangeType doesn't account for skipped transititions #21

Open
Gnuxie opened this issue Apr 4, 2024 · 0 comments
Open

MembershipChangeType doesn't account for skipped transititions #21

Gnuxie opened this issue Apr 4, 2024 · 0 comments

Comments

@Gnuxie
Copy link
Owner

Gnuxie commented Apr 4, 2024

For example leave->leave implies a user temporarily rejoined the room, so it's wrong to classify it as NoChange since we might want to warn protections about the rejoin even if we don't have a record of it (because of downtime). Of course, all of these special cases have to have to be its own enum variant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant