Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MembershipChangeType Rejoined is probably error prone #22

Open
Gnuxie opened this issue Apr 4, 2024 · 0 comments
Open

MembershipChangeType Rejoined is probably error prone #22

Gnuxie opened this issue Apr 4, 2024 · 0 comments

Comments

@Gnuxie
Copy link
Owner

Gnuxie commented Apr 4, 2024

Given a user rejecting an invite or being kicked on knock for the first time and later joining again probably shouldn't be classified as rejoined as they never did really join the room. Of course, this relies on transitions being skipped from our perspective due to downtime and not chasing up the chain of events, because normally the user would be classified as renocked or reinvited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant