Ensure PolicyListRevisionIssuers and their dependents are intialized in a consistent way
#3
Comments
|
Distinguishing whether the changes are from initialising the revision or not can be done by checking if the previous revision was empty. |
Gnuxie
added a commit
that referenced
this issue
Oct 26, 2023
- User rules shouldn't return server rules unless asked for explicitly, this was weird behavior from mjolnir. - Add better mechanisms for finding rules for entities, these aren't great, and there probably is a better way to optimize. - We now need to implement #3
Gnuxie
added a commit
that referenced
this issue
Oct 26, 2023
Related #3. Though I don't think it fixes it, since propagator revision issuers don't have a way to signal that they've added/removed entire revisions from their incorperated revision.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This can be done by enforcing that the initial data that is used to build a revision (e.g. when fetching state for the first time) is done so from calling
reviseFromChanges/reviseFromStateon an empty revision (blankRevision). Then adding a flag to therevisionevent (or an event that can be subscribed to withonce(i don't think the latter is necessary given everything will need to subscribe to this events, and only client code will need to distinguish between the two).The text was updated successfully, but these errors were encountered: