Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetRoomState/SetRoomMembership 'revision' event consistency #36

Open
Gnuxie opened this issue May 1, 2024 · 0 comments
Open

SetRoomState/SetRoomMembership 'revision' event consistency #36

Gnuxie opened this issue May 1, 2024 · 0 comments

Comments

@Gnuxie
Copy link
Owner

Gnuxie commented May 1, 2024

So I was wondering if I needed to create a new listener specifically for when the ProtectedRoomsManagergets a call to addRoom. Instead of just abusing the existing 'revision' event in the setRoomState and membership objects.

When a new policy list is added to the PolicyListsConfig, the issuer manager creates a revision that incorporates all these new changes. But that's because the revision represents the final result of all config and fancy filtering.

So the thing is the protection handles for handleStateChange and handleMembershipChange are called when the setRoomState emits the revision event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant