New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`Context` object in Protections only exists because different consequence providers can't be configured to be given to different protections. #4

Open

Gnuxie opened this issue Nov 28, 2023 · 0 comments

Owner

Gnuxie commented Nov 28, 2023

If protections need additional authority than provided by the consequence provider, then they should be able to get a consequence provider with a different interface and be configured to handle that. https://github.com/Gnuxie/matrix-protection-suite/blob/main/src/Protection/ProtectionsConfig/ProtectionsConfig.ts#L51

It's important that we remove the context object as soon as we have the config support for matching up different providers to different protections. https://github.com/Gnuxie/matrix-protection-suite/blob/main/src/Protection/ProtectionsConfig/MjolnirProtectionsConfig.ts#L45-L46. This is the only way to make a safe "dry run" mode of Draupnir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment