Improve speculation rules handling based on element visibility #446
+80
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI fails, please make sure tests are valid. |
|
TODO in order to complete merge this PR:
|
westonruter
reviewed
May 27, 2025
Changed "urlsToPrerender" property type on JSDoc Co-authored-by: Weston Ruter <westonruter@gmail.com>
gilbertococchi
approved these changes
May 30, 2025
|
Thanks @giorgiopellegrino for adding the documentation changes, can you please add them as part of this PR? Context: giorgiopellegrino@f522eef |
westonruter
reviewed
May 30, 2025
westonruter
reviewed
May 30, 2025
Error return type object Co-authored-by: Weston Ruter <westonruter@gmail.com>
const variable specRulesInViewport Co-authored-by: Weston Ruter <westonruter@gmail.com>
gilbertococchi
approved these changes
Jun 3, 2025
Added functionality to the listen({ prerender: true }) method to allow prerendering only of content within the viewport, and introduced the eagerness property to the prerender method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description:
This pull request addresses the issue raised in #442 by enhancing how speculation rules are managed based on the visibility of DOM elements.
Specifically, speculation rules are now added only when the target element is within the viewport and removed when it exits the viewport. This change enables developers to safely use
quicklink.listen(el, { prerender: true, eagerness: 'immediate' })on mobile devices without the risk of hitting the browser-imposed limit of 10 prerendered pages.This implementation improves resource management and ensures a more efficient and predictable prerendering behavior.
Thanks,
Giorgio Pellegrino.
cc @gilbertococchi