Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dumping multiple Spanner databases to Avro #38

Open
CAFxX opened this issue Jun 3, 2019 · 7 comments
Open

Support dumping multiple Spanner databases to Avro #38

CAFxX opened this issue Jun 3, 2019 · 7 comments
Assignees
Labels
addition New feature or request blocked Blocked by new features from Cloud Dataflow Spanner

Comments

@CAFxX
Copy link

CAFxX commented Jun 3, 2019

To be able to use Cloud Scheduler effectively with the Spanner->Avro template, it would be ideal if https://github.com/GoogleCloudPlatform/DataflowTemplates/blob/master/src/main/java/com/google/cloud/teleport/spanner/ExportPipeline.java allowed specifying multiple Database IDs (instead of a single one, as happens currently)

The current template already creates a subdirectory for the exported database in the GCS output directory: if multiple databases were specified multiple subdirectories would be created, one for each database.

As an extension, it would be very useful even to make the Database ID optional, in which case the dataflow would have to enumerate the databases in the specified Spanner instance, and then export all of them.

The goal is to be able to trigger an export of one, multiple or all databases on a spanner instance from a cloud scheduler job.

@azurezyq
Copy link
Contributor

azurezyq commented Jun 6, 2019

Agreed that this would be very useful. However due to the nature of dataflow templates, job graph cannot be changed once the template is built. Which means that it would need more work on the template feature side to be able to support that.

We are working on something which would remove the limitation mentioned above. Will revisit this soon.

@azurezyq azurezyq self-assigned this Jun 6, 2019
@azurezyq azurezyq added addition New feature or request blocked Blocked by new features from Cloud Dataflow labels Jun 6, 2019
@CAFxX
Copy link
Author

CAFxX commented Jun 11, 2019

@azurezyq thanks for the reply.

However due to the nature of dataflow templates, job graph cannot be changed once the template is built.

Just to confirm: does this apply even if the databases are exported serially?

Just FTR I also filed the same request via enterprise support: https://console.cloud.google.com/support/cases/detail/19577487?folder&organizationId=956776603191

Copy link

This issue has been marked as stale due to 180 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the issue at any time. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jun 13, 2024
@CAFxX
Copy link
Author

CAFxX commented Jun 13, 2024

Issue isn't solved yet

@github-actions github-actions bot removed the stale label Jul 26, 2024
Copy link

This issue has been marked as stale due to 180 days of inactivity. It will be closed in 1 week if no further activity occurs. If you think that’s incorrect or this pull request requires a review, please simply write any comment. If closed, you can revive the issue at any time. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 22, 2025
@CAFxX
Copy link
Author

CAFxX commented Jan 22, 2025

Issue isn't solved yet

@azurezyq
Copy link
Contributor

I no longer work on this project. This kind of issue should be able to be solved via the new dataflow flex templates.
It seems that I cannot unassign myself from the issue though. The current owner of the repo can triage.

Thanks.

@github-actions github-actions bot removed the stale label Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addition New feature or request blocked Blocked by new features from Cloud Dataflow Spanner
Projects
None yet
Development

No branches or pull requests

3 participants