From 7c3ba7563593caedb3ef0d1b72dbfc9d115023b6 Mon Sep 17 00:00:00 2001 From: sophieyfang Date: Tue, 3 Jan 2023 13:33:00 -0500 Subject: [PATCH] Replace URI decode with CGI unescape (#497) --- test/plugin/base_test.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/plugin/base_test.rb b/test/plugin/base_test.rb index 2aacb19c..a3b470b8 100644 --- a/test/plugin/base_test.rb +++ b/test/plugin/base_test.rb @@ -21,6 +21,7 @@ require 'mocha/test_unit' require 'prometheus/client' require 'webmock/test_unit' +require 'cgi' require_relative 'asserts' require_relative 'constants' @@ -823,7 +824,7 @@ def test_reject_non_utf8_container_name_with_require_valid_tags_true params = CONTAINER_FROM_METADATA_PARAMS.merge( labels: CONTAINER_FROM_METADATA_PARAMS[:labels].merge( "#{GKE_CONSTANTS[:service]}/container_name" => - URI.decode(encoded_name)), + CGI.unescape(encoded_name)), log_name: encoded_name) verify_log_entries(0, params, 'textPayload') end @@ -906,7 +907,7 @@ def test_sanitize_tags_from_container_name_with_require_valid_tags_false params = CONTAINER_FROM_METADATA_PARAMS.merge( resource: CONTAINER_FROM_METADATA_PARAMS[:resource].merge( labels: CONTAINER_FROM_METADATA_PARAMS[:resource][:labels].merge( - 'container_name' => URI.decode(encoded_container_name))), + 'container_name' => CGI.unescape(encoded_container_name))), log_name: encoded_container_name) verify_log_entries(1, params, 'textPayload') end