Skip to content

chore: add back region tags for sample browser #10101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

chore: add back region tags for sample browser #10101

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29c953b
chore: add back region tags for sample browser
iennae Jun 5, 2025
1788e28
fix: address linting error with empty space requried
iennae Jun 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions retail/interactive-tutorials/src/main/java/product/AddFulfillmentPlaces.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@
* limitations under the License.
*/

// [START retail_add_fulfillment_places]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: excess space after region tag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's a required empty line according to lint (I don't see an extra space at the end of the line?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can always do a followup edit to remove as I'm not sure what the extra space is, but really need this to exist so I can show folks how to get sample browser working. Thanks for the review!

package product;

import static setup.SetupCleanup.createProduct;
Expand Down Expand Up @@ -81,3 +83,4 @@ public static void addFulfillmentPlaces(String productName, String placeId)
}
}
}
// [END retail_add_fulfillment_places]