Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IODynamicClass redundant init variables #58

Open
Retiefasaurus opened this issue Nov 24, 2023 · 1 comment
Open

IODynamicClass redundant init variables #58

Retiefasaurus opened this issue Nov 24, 2023 · 1 comment
Assignees

Comments

@Retiefasaurus
Copy link
Collaborator

Is obs_data, sim_data necessary for the IODynamic class if it reads files?
@chyalexcheng

    def __init__(
        self,
        sim_name: str,
        sim_data_dir: str,
        sim_data_file_ext: str,
        obs_data_file: str,
        obs_names: List[str],
        ctrl_name: str,
        num_samples: int,
        param_min: List[float],
        param_max: List[float],
        obs_data: np.ndarray = None,
        ctrl_data: np.ndarray = None,
        inv_obs_weight: List[float] = None,
        sim_data: np.ndarray = None,
        callback: Callable = None,
        curr_iter: int = 0,
        param_data_file: str = '',
        param_data: np.ndarray = None,
        param_names: List[str] = None,
    ):
@Retiefasaurus Retiefasaurus changed the title IODynamicClass redundant init IODynamicClass redundant init variables Nov 24, 2023
@chyalexcheng
Copy link
Contributor

Yes, the inference class still needs them to calculate the likelihood.

@chyalexcheng chyalexcheng self-assigned this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants