Skip to content

Add proportional editing to the Path tool #2556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 48 commits into
base: master
Choose a base branch
from
Draft

Add proportional editing to the Path tool #2556

wants to merge 48 commits into from

Conversation

singhutsav5502
Copy link
Contributor

@singhutsav5502 singhutsav5502 commented Apr 11, 2025 •
edited
Loading

Adds Proportional Editing Mode

Functionality similar to Blenders Proportional Edit tool ported to Graphites 2D implementation.

Alt + P to toggle Proportional Editing mode.
Mouse Scroll Up/Down to increase/decrease Influence Radius.
Integrate with GRS tool.

Introduces 8 falloff types:

  1. Constant
  2. Linear
  3. Sharp
  4. Root
  5. Sphere
  6. Smooth
  7. Random
  8. Inverse Square

Closes #2557

@Keavon
Copy link
Member

Keavon commented Apr 11, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 3303996
https://ffda505b.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 11, 2025 •
edited
Loading

A few notes:

  • It should work with G/R/S
  • It should apply to the original drag starting location's range of points, not a continuously updating range of points (see comparison videos below)
  • It should only show the influence circle when dragging, not always when the feature is enabled

https://files.keavon.com/-/MiniatureDisguisedScarletibis/capture_34_.mp4 vs. https://files.keavon.com/-/SlipperyStridentCaiman/capture_35_.mp4

@Keavon
Copy link
Member

Keavon commented Apr 12, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 4c15fea
https://8e2c8c2e.graphite.pages.dev

@singhutsav5502
Copy link
Contributor Author

Hi, Still working on the integration with transformation.rs for the GRS functionality.

@singhutsav5502
Merge branch 'master' into proportional_editing
3ff5a0f
@singhutsav5502
Setup Proportional Edit for path tool
1a87daa
@singhutsav5502
Setup defaults, fix toolbar labels, fix falloff type selection
18c4506
@singhutsav5502
Implement storing original selection center and affected points for p…
b2b07bd 
…roportional edit
@singhutsav5502
Fix Proportional Edit influence circle render to selection center
eef4164
@singhutsav5502
Merge branch 'proportional_editing' of github.com:singhutsav5502/Grap…
8f5d4eb 
…hite into proportional_editing
@singhutsav5502
Setup initial GRS functionality
d78ed5b
@singhutsav5502
Basic integration with GRS tool, Edge Cases that still need handling:…
52563b9 
… Radius change updates GRS internal state, changing tool type should apply transform to influenced points as well
@singhutsav5502
Update Transform proportional edit data on radius update
eb9be0e
@singhutsav5502
All selected points are used as centers to find affeted points
953c42d
@singhutsav5502
Switching TransformOperation wthin GRS persists proportional_edit_dat…
588d63a 
…a until it's 'final_operation'
@singhutsav5502
Finalise GRS integration
b960b10
@singhutsav5502
Merge branch 'master' into proportional_editing
4e12de2
@singhutsav5502
Merge branch 'master' into proportional_editing
d60f6ea
@Keavon
Copy link
Member

Keavon commented Apr 13, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for d60f6ea
https://550fd3ac.graphite.pages.dev

@singhutsav5502
make sure radius change correctly repaints data position on proportio…
a6d36a0 
…nal edit
@singhutsav5502
Merge branch 'proportional_editing' of github.com:singhutsav5502/Grap…
ad14ffe 
…hite into proportional_editing
@singhutsav5502
Setup initial point location storage in path_tool and use it to calcu…
a26379c 
…late falloff factor even after original select has been moved ( useful when radius changes ), selection center remains centered based on the average original selection even when radius is changed
@Keavon
Copy link
Member

Keavon commented Apr 13, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for b35d2a1
https://86f25568.graphite.pages.dev

@Keavon Keavon changed the title Add the Proportional Editing feature to Path Tool Add proportional editing to Path Tool Apr 13, 2025
@Keavon Keavon changed the title Add proportional editing to Path Tool Add proportional editing to the Path tool Apr 13, 2025
@Keavon
Copy link
Member

Keavon commented Apr 15, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for f8a61c6
https://28714f29.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 15, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 9e9effb
https://22249c5c.graphite.pages.dev

@Keavon Keavon marked this pull request as draft April 20, 2025 07:41
@Keavon
Copy link
Member

Keavon commented Apr 24, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 075768b
https://73457d87.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Apr 24, 2025

Outstanding issues as communicated in Discord:

  • With rotation, points seem to converge inwards:

    capture_48_.mp4
    capture_49_.mp4

  • Dragging a point with the Path tool, as opposed to using G/R/S, is pretty broken:

    capture_87_.mp4

  • Performance really doesn't scale well, it gets super sluggish with a grid like in the video above

  • Your PR adds a lot of lines of code. I'll need you to break out most of the functionality into its own file dedicated to proportional editing, since this is too much specialized behavior in the path tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proportional editing mode
2 participants
@singhutsav5502 @Keavon