refactor(core): throw an error if filePath is not absolute

Author: meteorlxy

packages/@vuepress/core/__tests__/page/resolvePageFilePath.spec.ts

@@ -34,16 +34,21 @@ describe('core > page > resolvePageFilePath', () => {
     })
   })
 
-  it('should resolve path correctly if filePath is relative', () => {
-    const resolved = resolvePageFilePath({
-      app,
-      options: {
-        filePath: relativeFilePath,
-      },
-    })
-    expect(resolved).toEqual({
-      filePath: absoluteFilePath,
-      filePathRelative: relativeFilePath,
-    })
+  it('should throw if filePath is relative', () => {
+    const consoleError = console.error
+    console.error = jest.fn()
+
+    expect(() =>
+      resolvePageFilePath({
+        app,
+        options: {
+          filePath: relativeFilePath,
+        },
+      })
+    ).toThrow()
+
+    expect(console.error).toHaveBeenCalled()
+
+    console.error = consoleError
   })
 })

packages/@vuepress/core/src/page/resolvePageFilePath.ts

@@ -1,12 +1,12 @@
-import { path } from '@vuepress/utils'
+import { logger, path } from '@vuepress/utils'
 import type { App, PageOptions } from '../types'
 
 /**
  * Resolve absolute and relative path of page file
  */
 export const resolvePageFilePath = ({
   app,
-  options: { filePath },
+  options,
 }: {
   app: App
   options: PageOptions
@@ -15,15 +15,21 @@ export const resolvePageFilePath = ({
   filePathRelative: string | null
 } => {
   // empty file path
-  if (!filePath) {
+  if (!options.filePath) {
     return {
       filePath: null,
       filePathRelative: null,
     }
   }
 
+  if (!path.isAbsolute(options.filePath)) {
+    throw logger.createError(
+      `filePath is not absolute file path: ${options.filePath}}`
+    )
+  }
+
   return {
-    filePath,
-    filePathRelative: path.relative(app.dir.source(), filePath),
+    filePath: options.filePath,
+    filePathRelative: path.relative(app.dir.source(), options.filePath),
   }
 }

packages/@vuepress/core/src/page/resolvePagePath.ts

@@ -18,7 +18,7 @@ export const resolvePagePath = ({
 
   if (!pagePath) {
     throw logger.createError(
-      `page path is empty, page options: ${JSON.stringify(options)}`
+      `page path is empty, page options: ${JSON.stringify(options, null, 2)}`
     )
   }