Add tests for _validate_range method

Author: Grokzen

Diff for: pykwalify/core.py

@@ -657,6 +657,8 @@ def _validate_range(self, max_, min_, max_ex, min_ex, value, path, prefix):
         """
         Validate that value is within range values.
         """
+        if not isinstance(value, int) and not isinstance(value, float):
+            raise CoreError("Value must be a integer type")
 
         log.debug(
             u"Validate range : %s : %s : %s : %s : %s : %s",

Diff for: tests/test_core_methods.py

@@ -2,7 +2,7 @@
 from datetime import datetime
 
 from pykwalify.core import Core
-from pykwalify.errors import NotSequenceError
+from pykwalify.errors import NotSequenceError, CoreError
 
 
 class Rule(object):
@@ -28,6 +28,48 @@ def ec():
     return Core(source_data={}, schema_data={})
 
 
+def test_validate_range():
+    data_matrix = [
+        (10, 5, 10, 5, 7, []),
+        (None, None, None, None, 7, []),
+
+        (10, 5, None, None, 13, ["Type 'prefix' has size of '13', greater than max limit '10'. Path: '/'"]),
+        (10, 5, None, None, 3, ["Type 'prefix' has size of '3', less than min limit '5'. Path: '/'"]),
+        (10, 5, None, None, 13.5, ["Type 'prefix' has size of '13.5', greater than max limit '10'. Path: '/'"]),
+        (10, 5, None, None, 3.5, ["Type 'prefix' has size of '3.5', less than min limit '5'. Path: '/'"]),
+        (10, 5, None, None, 10, []),
+        (10, 5, None, None, 5, []),
+        (10, 5, None, None, 10.0, []),
+        (10, 5, None, None, 5.0, []),
+
+        (None, None, 10, 5, 13, ["Type 'prefix' has size of '13', greater than or equals to max limit(exclusive) '10'. Path: '/'"]),
+        (None, None, 10, 5, 3, ["Type 'prefix' has size of '3', less than or equals to min limit(exclusive) '5'. Path: '/'"]),
+        (None, None, 10, 5, 13.5, ["Type 'prefix' has size of '13.5', greater than or equals to max limit(exclusive) '10'. Path: '/'"]),
+        (None, None, 10, 5, 3.5, ["Type 'prefix' has size of '3.5', less than or equals to min limit(exclusive) '5'. Path: '/'"]),
+        (None, None, 10, 5, 10, ["Type 'prefix' has size of '10', greater than or equals to max limit(exclusive) '10'. Path: '/'"]),
+        (None, None, 10, 5, 5, ["Type 'prefix' has size of '5', less than or equals to min limit(exclusive) '5'. Path: '/'"]),
+        (None, None, 10, 5, 8, []),
+        (None, None, 10, 5, 7, []),
+        (None, None, 10, 5, 8.5, []),
+        (None, None, 10, 5, 7.5, []),
+    ]
+
+    for max_, min_, max_ex, min_ex, value, errors in data_matrix:
+        print("Testing data: {} {} {} {} {}".format(max_, min_, max_ex, min_ex, value))
+        c = ec()
+        c._validate_range(max_, min_, max_ex, min_ex, value, '/', 'prefix')
+        assert _remap_errors(c) == errors
+
+    # Test value type validation inside the method
+    with pytest.raises(CoreError):
+        c = ec()
+        c._validate_range(5, 1, None, None, [1, 2, 3], '/', 'prefix')
+
+    with pytest.raises(CoreError):
+        c = ec()
+        c._validate_range(5, 1, None, None, {'a': 1, 'b': 2, 'c': 3}, '/', 'prefix')
+
+
 def test_validate_timestamp():
     data_matrix = [
         ("", ["Timestamp value is empty. Path: ''"]),