Fix incorrect option mask returned by SDgetcompinfo #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description:
A special bit, SZ_H4_REV_2, was used to indicate that the szip info
was stored in a new way. This bit was set in the options_mask field
of the szip info struct. As a result, the value of options_mask became
incorrect.
This PR removed the special bit from the options_mask before returning it
to the application. This change does not affect the data format in the
file.
bmribler
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
|
Definitely need to un-uncomment the mfhdf/fortran/tszip.f code around line 280 |
derobins
added
Component - C Library
|
Need to rework |
Added tests for options_mask from SDgetcompinfo and SDgetchunkinfo
|
Sorry for the size of this PR. HDFFR-82 only reported SDgetcompinfo but it turned out GRgetcompinfo and SDgetchunkinfo were affected by the same bug. |
byrnHDF
approved these changes
Feb 3, 2024
|
Additional work for Java and Fortran. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A special bit, SZ_H4_REV_2, was used to indicate that the szip info was stored in a new way. This bit was set in the options_mask field of the szip info struct. As a result, the value of options_mask became incorrect.
This PR removed the special bit from the options_mask before returning it to the application. This change does not affect the data format in the file.
(JIRA issue HDFFR-82)