Code cleanup - Remove getcompress functions #477
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Description:
A special bit, SZ_H4_REV_2, was used to indicate that the szip info
was stored in a new way. This bit was set in the options_mask field
of the szip info struct. As a result, the value of options_mask became
incorrect.
This PR removed the special bit from the options_mask before returning it
to the application. This change does not affect the data format in the
file.
Description:
The functions SDgetcompress/GRgetcompress have incorrect behavior and
were deprecated in favor of SDgetcompinfo/GRgetcompinfo several
versions ago. They should not be used anymore.
Removed the internal function HCPgetcompress and replaced the
contents of SDgetcompress/GRgetcompress with a call to
SDgetcompinfo/GRgetcompinfo.
bmribler
requested review from
lrknox,
derobins,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
|
We should take them out of Java with deprecate tag. And just remove the tests. |
derobins
added
Component - C Library
byrnHDF
approved these changes
Feb 5, 2024
HCP routines were not added to Java, so this is not an issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functions SDgetcompress/GRgetcompress have incorrect behavior and were deprecated in favor of SDgetcompinfo/GRgetcompinfo several releases ago. They should not be used anymore.
Removed the internal function HCPgetcompress and replaced the contents of SDgetcompress/GRgetcompress with a call to SDgetcompinfo/GRgetcompinfo.