Fix all maybe-uninitialized warnings #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derobins
added
Component - C Library
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
derobins
commented
Feb 4, 2024
| @@ -664,8 +664,7 @@ putElement(char *file, uint16 tag, uint16 ref, char *data, int32 len) | |||
| int | |||
| writeGrp(char *file) | |||
| { | |||
| int i; | |||
| uint16 ref; | |||
| uint16 ref = DFREF_NONE; | |||
There was a problem hiding this comment.
Not initialized (DFREF_NONE is the best "bad" value)
derobins
commented
Feb 4, 2024
| @@ -892,39 +892,41 @@ do_list(intn curr_arg, intn argc, char *argv[], intn help) | |||
| int32 an_id = FAIL; /* annotation interface handle */ | |||
| intn ret_value = SUCCEED; | |||
|
|
|||
| /* Do this early, to avoid uninitialized warnings in cleanup code */ | |||
| init_list_opts(&list_opts); | |||
|
|
|||
There was a problem hiding this comment.
This was initialized after some goto done calls, so the compiler complains about the string in list_opts not always being initialized.
derobins
commented
Feb 4, 2024
| @@ -2501,7 +2501,7 @@ pixrep(struct Input *in, struct Raster *im) | |||
| static int32 | |||
| create_SDS(int32 sd_id, int32 nt, struct Input *in) | |||
| { | |||
| int32 sds_id; | |||
| int32 sds_id = FAIL; | |||
There was a problem hiding this comment.
Uninitialized. FAIL is the "bad" value.
derobins
commented
Feb 4, 2024
| @@ -2712,7 +2712,8 @@ process(struct Options *opt) | |||
| int32 len; | |||
| FILE *strm = NULL; | |||
| int32 hdf; | |||
| int32 sd_id, sds_id; | |||
| int32 sd_id = FAIL; | |||
| int32 sds_id = FAIL; | |||
There was a problem hiding this comment.
Uninitialized. FAIL is the "bad" value.
derobins
commented
Feb 4, 2024
| @@ -88,7 +88,8 @@ test_dim1_SDS1(void) | |||
| float32 sds1_data[] = {0.1, 2.3, 4.5, 6.7, 8.9}; | |||
| float32 out_data[5]; | |||
| int32 dimsize[1]; | |||
| int32 sds_id, file_id, dim_id, index; | |||
| int32 sds_id, file_id, dim_id; | |||
| int32 index = FAIL; | |||
There was a problem hiding this comment.
Uninitialized. FAIL is the "bad" value.
byrnHDF
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.