Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync and reduce examples files #513

Merged
merged 8 commits into from
Feb 12, 2024

Conversation

byrnHDF
Copy link
Collaborator

@byrnHDF byrnHDF commented Feb 9, 2024

The HDF5Examples files are duplicates of those in the library, this syncs the changes made in those files before removing those files from the source. As in HDF5, we will need to add install commands and scripts to autotools.

@byrnHDF byrnHDF added Component - Build CMake, Autotools Component - Misc Anything else (CODEOWNERS, etc.) Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Type - Improvement Improvements that don't add a new feature or functionality Priority - 1. High 🔼 These are important issues that should be resolved in the next release labels Feb 9, 2024
@byrnHDF byrnHDF self-assigned this Feb 9, 2024

/********************** End of variable declaration **********************/

/*
* Open the HDF file.
* Create the HDF file.
Copy link
Collaborator

@bmribler bmribler Feb 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an open, not create. Am I missing something?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No probably was right then the merge from library messed it up.

@lrknox lrknox merged commit be9b9c9 into HDFGroup:master Feb 12, 2024
31 checks passed
@byrnHDF byrnHDF deleted the master-synch_and_reduce-ex branch February 12, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - Build CMake, Autotools Component - Misc Anything else (CODEOWNERS, etc.) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants