Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move types from hdfi.h to hdf.h #519

Closed
wants to merge 2 commits into from
Closed

Move types from hdfi.h to hdf.h #519

wants to merge 2 commits into from

Conversation

derobins
Copy link
Member

No description provided.

Dana Robinson added 2 commits February 12, 2024 20:46
Remove Fortran FRETVAL macros
fe1ab0d 
These are no longer necessary. The FCALLKEYW macro they enable is
not used, the logic makes no sense, and many functions already
omit FRETVAL().
Moves some things from hdfi.h to hdf.h
f79abc0 
Some things in hdfi.h, like the C99-like types, need to be in the
public API and should be in hdf.h.
@derobins derobins added Component - C Library Core C library issues Type - Improvement Improvements that don't add a new feature or functionality Priority - 1. High 🔼 These are important issues that should be resolved in the next release labels Feb 13, 2024
@derobins
Copy link
Member Author

Dangit

@derobins derobins closed this Feb 13, 2024
@derobins derobins deleted the move_types_to_hdf_h branch March 3, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@byrnHDF byrnHDF Awaiting requested review from byrnHDF byrnHDF is a code owner

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@schwehr schwehr Awaiting requested review from schwehr schwehr is a code owner

Assignees
No one assigned
Labels
Component - C Library Core C library issues Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Improvement Improvements that don't add a new feature or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@derobins