hdfi.h is no longer included in hdf.h #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the past, hdfi.h (an internal header file) was included in the
public hdf.h header. This is no longer the case. Anything that
should be public has been moved from hdfi.h to hdf.h, including:
* The C99-like types (e.g., float32)
* The archaic VOID/VOIDP macros
* The intf Fortran integer type
* The HD library macros (e.g., HDmalloc)
All of these things are considered obsolete and we only maintain
them in the public header so that old code does not have to be
modified. It is unwise to use them in new code.
derobins
added
Component - C Library
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
derobins
commented
Feb 13, 2024
| @@ -14,8 +14,6 @@ | |||
| #ifndef H4_API_ADPT_H | |||
| #define H4_API_ADPT_H | |||
|
|
|||
| #include "h4config.h" | |||
|
|
|||
|
Wherever possible, internal library and test source/headers include hdfi.h. Tools and utility code only include hdf.h, wherever possible. |
added 7 commits
February 13, 2024 03:27
min() and MSDOS from hdf/util/hdfgifwr.c
|
Yay |
byrnHDF
approved these changes
Feb 13, 2024
bmribler
approved these changes
Feb 13, 2024
| #include "hdatainfo.h" /* Add the data info header */ | ||
| #include "vg.h" /* Add the Vgroup/Vdata header so the users don't have to */ | ||
| #include "mfgr.h" /* Add the GR header so the users don't have to */ | ||
| #include "hdatainfo.h" /* data info header */ |
There was a problem hiding this comment.
hdatainfo.h can be left out entirely, same for mfhdf/libsrc/mdatainfo.h
There was a problem hiding this comment.
We can remove it in a future PR, when we remove the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, hdfi.h (an internal header file) was included in the
public hdf.h header. This is no longer the case. Anything that
should be public has been moved from hdfi.h to hdf.h, including:
All of these things are considered obsolete and we only maintain
them in the public header so that old code does not have to be
modified. It is unwise to use them in new code.