Remove unused Duff's device ifdefs #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derobins
added
Component - C Library
derobins
requested review from
lrknox,
byrnHDF,
fortnern,
jhendersonHDF,
qkoziol,
vchoi-hdfgroup,
bmribler,
glennsong09,
mattjala,
brtnfld and
schwehr
as code owners
derobins
commented
Feb 13, 2024
| /* Don't know why. -AKC 2014/1/18 */ | ||
| #define DUFF | ||
| #ifdef DUFF | ||
| #define DUFF_sb4b |
There was a problem hiding this comment.
This is the only one of these symbols that is used, and it's ALWAYS set
derobins
commented
Feb 13, 2024
| @@ -245,7 +218,6 @@ DFKsb4b(void *s, void *d, uint32 num_elm, uint32 source_stride, uint32 dest_stri | |||
| source += 4; | |||
| } while (--n > 0); | |||
| } | |||
| #endif /* DUFF_sb4b */ | |||
There was a problem hiding this comment.
Since DUFF_sb4b is always set, I just removed the dead code
byrnHDF
approved these changes
Feb 13, 2024
bmribler
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.