Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead code from testcdf.h #529

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Remove dead code from testcdf.h #529

merged 1 commit into from
Feb 14, 2024

Conversation

derobins
Copy link
Member

No description provided.

@derobins derobins added Component - netCDF netCDF interface and nc* command-line tools Component - Testing Test code, GitHub workflows Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. labels Feb 13, 2024
derobins
derobins commented Feb 13, 2024
View reviewed changes
mfhdf/nctest/testcdf.h
#ifdef DELETE_CHUNK
void *emalloc();
void *erealloc();
#endif
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DELETE_CHUNK isn't defined in the codebase

@lrknox lrknox merged commit 799783e into HDFGroup:master Feb 14, 2024
31 checks passed
@derobins derobins deleted the testcdf_dead_code branch March 3, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrknox lrknox lrknox approved these changes

@byrnHDF byrnHDF byrnHDF approved these changes

@fortnern fortnern Awaiting requested review from fortnern fortnern is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

@qkoziol qkoziol Awaiting requested review from qkoziol

@vchoi-hdfgroup vchoi-hdfgroup Awaiting requested review from vchoi-hdfgroup vchoi-hdfgroup is a code owner

@bmribler bmribler Awaiting requested review from bmribler bmribler is a code owner

@glennsong09 glennsong09 Awaiting requested review from glennsong09 glennsong09 is a code owner

@mattjala mattjala Awaiting requested review from mattjala mattjala is a code owner

@brtnfld brtnfld Awaiting requested review from brtnfld brtnfld is a code owner

@schwehr schwehr Awaiting requested review from schwehr schwehr is a code owner

Assignees
No one assigned
Labels
Component - netCDF netCDF interface and nc* command-line tools Component - Testing Test code, GitHub workflows Priority - 3. Low 🔽 Code cleanup, small feature change requests, etc. Type - Deprecation / Removal We strive for backward-compatibility, so it's worth noting this separately
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@derobins @lrknox @byrnHDF