Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set signtool path for ant build workflow #312

Closed
wants to merge 1 commit into from
Closed

Set signtool path for ant build workflow #312

wants to merge 1 commit into from

Conversation

hyoklee
Copy link
Member

@hyoklee hyoklee commented Aug 13, 2024

This will remove signtool not found error during ant build process.

byrnHDF
byrnHDF reviewed Aug 13, 2024
View reviewed changes
Copy link
Collaborator

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While correct, this is not future-proof if the path changes.
Would be better if there is a way to get the value from the registry.

byrnHDF
byrnHDF reviewed Aug 14, 2024
View reviewed changes
Copy link
Collaborator

@byrnHDF byrnHDF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added to PR 311

@byrnHDF byrnHDF closed this Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@byrnHDF byrnHDF byrnHDF left review comments

@lrknox lrknox Awaiting requested review from lrknox lrknox is a code owner

@jhendersonHDF jhendersonHDF Awaiting requested review from jhendersonHDF jhendersonHDF is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hyoklee @byrnHDF