Skip to content

[Bug] Manual user "can_download" get's overwritten by AutoGroup system #1820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Alkl58 opened this issue Jun 28, 2021 · 5 comments
Closed

[Bug] Manual user "can_download" get's overwritten by AutoGroup system #1820

Alkl58 opened this issue Jun 28, 2021 · 5 comments

Comments

@Alkl58
Copy link
Contributor

Alkl58 commented Jun 28, 2021

Describe the bug
When setting the download permission of a user, it's gets overwritten in certain intervals by the AutoGroup system.

To Reproduce
Steps to reproduce the behavior:

  1. Set "can_download" from a user
  2. Wait for AutoGroup / or some other system
  3. See the user getting the can_download permission back

Expected behavior
AutoGroup System should respect the pemission set to a specific user.

Screenshots
n/a

UNIT3D (please complete the following information):

  • UNIT3D Version: v5.3.0
  • Laravel Version: Ver. 8.43.0
  • PHP Version: php8.0.7
  • Database Driver & Version: 8.0.25-0ubuntu0.20.04.1
  • Web Server Driver & Version: ubuntu 20.04
  • OS Driver and Version: ubuntu 20.04

Desktop (please complete the following information):

  • OS: n/a
  • Browser: n/a
  • Version: n/a

Additional context
I am not entirely sure if it is the AutoGroup System, but this is the most likely culprit.

Possible Fix?
n/a

Upvote & Fund

  • We're using Polar.sh so you can upvote and help fund this issue.
  • We receive the funding once the issue is completed & confirmed by you.
  • Thank you in advance for helping prioritize & fund our backlog.
Fund with Polar
@Alkl58 Alkl58 added the Bug label Jun 28, 2021
@HDVinnie HDVinnie removed their assignment Jul 4, 2021
@Alkl58
Copy link
Contributor Author

Alkl58 commented Jul 8, 2021

Issue seems to be:
https://github.com/HDInnovations/UNIT3D-Community-Edition/blob/f801b148dbc316a01ee7444f12e43c100f002205/app/Console/Commands/AutoRevokePermissions.php#L56

In my opinion this line is not needed, as 'can_download' => '1' should be set by autogroup.

@HDVinnie HDVinnie added the hacktoberfest hacktoberfest 2021 label Sep 14, 2021
@HDVinnie
Copy link
Collaborator

This will be resolved in @clandestine8 RBAC branch

@HDVinnie HDVinnie removed the hacktoberfest hacktoberfest 2021 label Jul 6, 2022
@HDVinnie HDVinnie linked a pull request Nov 28, 2022 that will close this issue
@HDVinnie HDVinnie linked a pull request Oct 13, 2023 that will close this issue
@HDVinnie HDVinnie added Fund and removed PR Welcome! labels Mar 9, 2024
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
…ey should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler every hour. Relevant issue: HDInnovations#1820.
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
…ey should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler every hour. Relevant issue: HDInnovations#1820.
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
…ey should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler every hour. Relevant issue: HDInnovations#1820.
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler every hour. Relevant issue: HDInnovations#1820.
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler every hour. Relevant issue: HDInnovations#1820.
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler every hour. Relevant issue: HDInnovations#1820.
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler every hour. Relevant issue: HDInnovations#1820.
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler every hour. Relevant issue: HDInnovations#1820.
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler every hour. Relevant issue: HDInnovations#1820.
Roardom added a commit to Roardom/UNIT3D that referenced this issue Jul 26, 2024
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler. Relevant issue: HDInnovations#1820.
@Audionut
Copy link

This seems fixed now.

@Roardom
Copy link
Collaborator

Roardom commented Aug 11, 2024

Obi-Wana pushed a commit to Obi-Wana/UNIT3D-Community-Edition that referenced this issue Aug 11, 2024
These permissions were never meant to be directly edited by staff. They should never have been added to the staff user edit page as it just caused confusion when the settings reset at the daily group change. I've now added these settings to the group directly and allow the settings on the user edit page to override the group settings. I refrained from fixing the can_download permission for now, because so many different things affect it and it will need at 3 separate permissions to control everything it does. Trying to fix it will take much more effort than what can be fixed today. Because of this, I removed the setting from the user edit page to reduce confusion from staff who don't realize it is controlled by the scheduler. Relevant issue: HDInnovations#1820.
@HDVinnie HDVinnie removed the Fund label Dec 24, 2024
@Roardom
Copy link
Collaborator

Roardom commented Jan 17, 2025

Related: #4428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants