(Update) Style tweaks and donation transaction wrapping #4434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roardom
requested changes
Jan 19, 2025
| @@ -560,7 +560,7 @@ a { | |||
| } | |||
|
|
|||
| .text-muted { | |||
| color: #0e111c; | |||
| color: #808080; | |||
There was a problem hiding this comment.
I took a look through the entire codebase, and the only place this css class is used is on the 2fa page. It might be a good idea to just let the default colors be used on the 2fa page and remove this class everywhere. It'd be nice to remove it from the _shame.scss anyways.
There was a problem hiding this comment.
Explains why I didn't initially notice it, feel like a better solution would be to update the page a little bit to match the style of the other pages, looks like it was left behind a while ago.
HDVinnie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes muted-text colors on the material navy theme, adds a drop shadow to the secondary navigation bar on all themes, and wraps extremely long transactions inputs on the staffs donation index. Users sometimes paste really long strings making it annoying to see all the elements without scrolling horizontally.