Skip to content

Commit 90f48a6

Browse files
committed
Warnings Fixes
1 parent 64aaaa7 commit 90f48a6

File tree

56 files changed

+280
-324
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

56 files changed

+280
-324
lines changed

dynamic/src/ext.rs

+4-3
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,7 @@ impl BomaExt for BattleObjectModuleAccessor {
909909

910910
unsafe fn handle_waveland(&mut self, require_airdodge: bool) -> bool {
911911
// MotionModule::frame(self) > 5.0 && !WorkModule::is_flag(self, *FIGHTER_STATUS_ESCAPE_FLAG_HIT_XLU);
912-
if (require_airdodge && !self.is_status_one_of(&[*FIGHTER_STATUS_KIND_ESCAPE_AIR, *FIGHTER_STATUS_KIND_ESCAPE_AIR_SLIDE])) {
912+
if require_airdodge && !self.is_status_one_of(&[*FIGHTER_STATUS_KIND_ESCAPE_AIR, *FIGHTER_STATUS_KIND_ESCAPE_AIR_SLIDE]) {
913913
return false;
914914
}
915915

@@ -1128,8 +1128,8 @@ impl BomaExt for BattleObjectModuleAccessor {
11281128
//let p2_x = -9.6;
11291129
//let p2_y = 9.0;
11301130

1131-
self.set_front_cliff_hangdata(p1_x, (p1_y - p2_y));
1132-
self.set_back_cliff_hangdata((p2_x * -1.0), (p1_y - p2_y));
1131+
self.set_front_cliff_hangdata(p1_x, p1_y - p2_y);
1132+
self.set_back_cliff_hangdata(p2_x * -1.0, p1_y - p2_y);
11331133
self.set_center_cliff_hangdata(0.0, p2_y);
11341134
}
11351135

@@ -1406,6 +1406,7 @@ pub struct ControllerMapping {
14061406
}
14071407

14081408
/// Controller class used internally by the game
1409+
#[allow(non_snake_case)]
14091410
#[repr(C)]
14101411
pub struct Controller {
14111412
pub vtable: *const u64,

dynamic/src/frame_info.rs

+1-12
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,10 @@
11
use smash::{
2-
app::{
3-
self,
4-
sv_animcmd::{
5-
frame,
6-
wait
7-
},
8-
lua_bind::*
9-
},
2+
app::lua_bind::*,
103
lib::lua_const::*,
114
lib::L2CAgent,
125
lua2cpp::*,
136
phx::*
147
};
15-
use smash_script::{
16-
*,
17-
macros::*
18-
};
198
use crate::{
209
*,
2110
consts::*,

dynamic/src/ui.rs

+1
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,7 @@ extern "C" {
5454
fn ui_manager_set_robot_meter_info(entry_id: u32, current: f32, max: f32, per_level: f32);
5555
}
5656

57+
#[allow(non_snake_case)]
5758
pub mod UiManager {
5859
pub fn set_dk_barrel_enable(entry_id: u32, enable: bool) {
5960
unsafe {

dynamic/src/util.rs

+5-5
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ use smash::app::{BattleObject, BattleObjectModuleAccessor};
22
use smash::lua2cpp::L2CFighterCommon;
33
use crate::offsets;
44
use crate::ext::*;
5-
use std::arch::asm;
5+
// use std::arch::asm;
66
use smash::phx::Vector2f;
7-
use crate::se;
7+
// use crate::se;
88

99
#[macro_export]
1010
macro_rules! dump_trace {
@@ -168,7 +168,7 @@ pub fn get_active_battle_object_id_from_entry_id(entry_id: u32) -> Option<u32> {
168168
pub unsafe fn get_all_active_battle_object_ids() -> Vec<u32> {
169169
use smash::lib::lua_const::*;
170170
use smash::app::lua_bind::*;
171-
use super::ext::*;
171+
// use super::ext::*;
172172
let mut vec: Vec<u32> = Vec::new();
173173
for entry_id in 0..8 {
174174
// get the active battle object id and add it to the list
@@ -253,8 +253,8 @@ struct SomeControllerStruct {
253253
pub unsafe fn get_controller_from_id(player: usize) -> &'static Controller {
254254
let base = *((skyline::hooks::getRegionAddress(skyline::hooks::Region::Text) as *mut u8)
255255
.add(0x5339860) as *const u64);
256-
let uVar3 = *((base + 0x298 + (4 * (player as u64))) as *const u32);
257-
let controller_struct = ((base + (0x8 * (uVar3 as i32)) as u64) as *mut SomeControllerStruct);
256+
let uvar3 = *((base + 0x298 + (4 * (player as u64))) as *const u32);
257+
let controller_struct = (base + (0x8 * (uvar3 as i32)) as u64) as *mut SomeControllerStruct;
258258
(*controller_struct).controller
259259
}
260260

fighters/bayonetta/src/status/specialairs.rs

+12-12
Original file line numberDiff line numberDiff line change
@@ -132,20 +132,20 @@ unsafe extern "C" fn bullet_movement(fighter: &mut L2CFighterCommon) -> L2CValue
132132
let y_reset = fighter.get_float(*FIGHTER_BAYONETTA_STATUS_WORK_ID_SPECIAL_AIR_S_U_FLOAT_MOTION_SPEED_Y);
133133
let initial_x = fighter.get_param_float("param_special_s", "ab_u_shooting_speed_x_mul");
134134
let initial_y = fighter.get_param_float("param_special_s", "ab_u_shooting_speed_y_mul");
135-
let mut stop_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_STOP) as *mut KineticEnergy; //272
136-
let mut gravity_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_GRAVITY) as *mut KineticEnergy; //288
137-
let mut motion_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_MOTION) as *mut KineticEnergy;
135+
let mut stop_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_STOP) as *mut app::KineticEnergy; //272
136+
let mut gravity_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_GRAVITY) as *mut app::KineticEnergy; //288
137+
let mut motion_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_MOTION) as *mut app::KineticEnergy;
138138
//motion to stop energy
139-
app::lua_bind::KineticEnergy::reset_energy(stop_energy as _, *ENERGY_STOP_RESET_TYPE_AIR, &Vector2f { x: x_reset * initial_x, y: 0.0 }, &Vector3f::zero(), fighter.module_accessor);
140-
lua_bind::KineticEnergyNormal::set_accel(stop_energy as *mut smash::app::KineticEnergyNormal, &Vector2f { x: 0.0, y: 0.0 });
141-
lua_bind::KineticEnergyNormal::set_brake(stop_energy as *mut smash::app::KineticEnergyNormal, &Vector2f { x: fighter.get_param_float("param_special_s", "ab_u_shooting_brake_speed_x"), y: 0.0 });
142-
lua_bind::KineticEnergyNormal::set_stable_speed(stop_energy as *mut smash::app::KineticEnergyNormal, &Vector2f { x: fighter.get_param_float("param_special_s", "ab_u_shooting_stable_speed_x"), y: 0.0 });
143-
lua_bind::KineticEnergyNormal::set_limit_speed(stop_energy as *mut smash::app::KineticEnergyNormal, &Vector2f { x: -1.0, y: -1.0 });
139+
lua_bind::KineticEnergy::reset_energy(stop_energy as _, *ENERGY_STOP_RESET_TYPE_AIR, &Vector2f { x: x_reset * initial_x, y: 0.0 }, &Vector3f::zero(), fighter.module_accessor);
140+
lua_bind::KineticEnergyNormal::set_accel(stop_energy as *mut app::KineticEnergyNormal, &Vector2f { x: 0.0, y: 0.0 });
141+
lua_bind::KineticEnergyNormal::set_brake(stop_energy as *mut app::KineticEnergyNormal, &Vector2f { x: fighter.get_param_float("param_special_s", "ab_u_shooting_brake_speed_x"), y: 0.0 });
142+
lua_bind::KineticEnergyNormal::set_stable_speed(stop_energy as *mut app::KineticEnergyNormal, &Vector2f { x: fighter.get_param_float("param_special_s", "ab_u_shooting_stable_speed_x"), y: 0.0 });
143+
lua_bind::KineticEnergyNormal::set_limit_speed(stop_energy as *mut app::KineticEnergyNormal, &Vector2f { x: -1.0, y: -1.0 });
144144
KineticModule::enable_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_STOP);
145145
//motion to gravity
146-
app::lua_bind::KineticEnergy::reset_energy(gravity_energy as _, *ENERGY_GRAVITY_RESET_TYPE_GRAVITY, &Vector2f { x: 0.0, y: initial_y }, &Vector3f::zero(), fighter.module_accessor);
147-
smash::app::lua_bind::FighterKineticEnergyGravity::set_accel(gravity_energy as *mut FighterKineticEnergyGravity, -fighter.get_param_float("param_special_s", "ab_u_shooting_accel_y"));
148-
smash::app::lua_bind::FighterKineticEnergyGravity::set_stable_speed(gravity_energy as *mut FighterKineticEnergyGravity, fighter.get_param_float("param_special_s", "ab_u_shooting_max_speed_y"));
146+
lua_bind::KineticEnergy::reset_energy(gravity_energy as _, *ENERGY_GRAVITY_RESET_TYPE_GRAVITY, &Vector2f { x: 0.0, y: initial_y }, &Vector3f::zero(), fighter.module_accessor);
147+
lua_bind::FighterKineticEnergyGravity::set_accel(gravity_energy as *mut app::FighterKineticEnergyGravity, -fighter.get_param_float("param_special_s", "ab_u_shooting_accel_y"));
148+
lua_bind::FighterKineticEnergyGravity::set_stable_speed(gravity_energy as *mut app::FighterKineticEnergyGravity, fighter.get_param_float("param_special_s", "ab_u_shooting_max_speed_y"));
149149
KineticModule::enable_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_GRAVITY);
150150
KineticModule::unable_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_MOTION);
151151
fighter.off_flag(*FIGHTER_BAYONETTA_STATUS_WORK_ID_SPECIAL_AIR_S_FLAG_WALL_CHECK);
@@ -161,7 +161,7 @@ unsafe extern "C" fn bullet_movement(fighter: &mut L2CFighterCommon) -> L2CValue
161161
}
162162
} else if fighter.get_int(*FIGHTER_BAYONETTA_STATUS_WORK_ID_SPECIAL_AIR_S_U_INT_STEP) == *FIGHTER_BAYONETTA_SHOOTING_STEP_SHOOTING { //shooting
163163
if fighter.get_int(*FIGHTER_BAYONETTA_INSTANCE_WORK_ID_INT_SHOOTING_STEP) != *FIGHTER_BAYONETTA_SHOOTING_STEP_SHOOTING {
164-
let stop_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_STOP) as *mut KineticEnergy;
164+
let stop_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_STOP) as *mut app::KineticEnergy;
165165
let speed = Vector2f{
166166
x: lua_bind::KineticEnergy::get_speed_x(stop_energy),
167167
y: lua_bind::KineticEnergy::get_speed_y(stop_energy)

fighters/chrom/src/opff.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -181,10 +181,10 @@ unsafe fn soaring_slash(fighter: &mut L2CFighterCommon) {
181181
}
182182

183183
pub unsafe fn double_edge_dance_vertical_momentum(fighter: &mut L2CFighterCommon){
184-
let fighter_gravity = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_GRAVITY) as *mut FighterKineticEnergyGravity;
184+
let fighter_gravity = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_GRAVITY) as *mut app::FighterKineticEnergyGravity;
185185
if fighter.is_status_one_of(&[*FIGHTER_STATUS_KIND_SPECIAL_S, *FIGHTER_ROY_STATUS_KIND_SPECIAL_S2]) && fighter.is_situation(*SITUATION_KIND_AIR) {
186-
smash::app::lua_bind::FighterKineticEnergyGravity::set_accel(fighter_gravity, -0.072);
187-
smash::app::lua_bind::FighterKineticEnergyGravity::set_stable_speed(fighter_gravity, -2.0);
186+
lua_bind::FighterKineticEnergyGravity::set_accel(fighter_gravity, -0.072);
187+
lua_bind::FighterKineticEnergyGravity::set_stable_speed(fighter_gravity, -2.0);
188188
}
189189

190190
if fighter.is_situation(*SITUATION_KIND_GROUND) && VarModule::is_flag(fighter.battle_object, vars::common::instance::SPECIAL_STALL_USED) {

fighters/chrom/src/status.rs

+13-13
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ use globals::*;
33
// status script import
44

55

6-
pub fn set_gravity_delay_resume_frame(energy: *mut FighterKineticEnergyGravity, frames: i32) {
6+
pub fn set_gravity_delay_resume_frame(energy: *mut app::FighterKineticEnergyGravity, frames: i32) {
77
unsafe {
88
*(energy as *mut i32).add(0x50 / 4) = frames;
99
*(energy as *mut bool).add(0x5C) = false;
@@ -15,9 +15,9 @@ pub unsafe extern "C" fn special_s_init(fighter: &mut L2CFighterCommon) -> L2CVa
1515
let customize_special_hi_no = WorkModule::get_int(fighter.module_accessor, *FIGHTER_INSTANCE_WORK_ID_INT_CUSTOMIZE_SPECIAL_HI_NO);
1616
let start_spd_x_mul = WorkModule::get_param_float(fighter.module_accessor, hash40("param_special_s"), hash40("start_spd_x_mul"));
1717
let air_spd_y = WorkModule::get_param_float(fighter.module_accessor, hash40("param_special_s"), hash40("air_spd_y"));
18-
let mut stop_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_STOP) as *mut KineticEnergy;
19-
let mut gravity_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_GRAVITY) as *mut KineticEnergy;
20-
let mut motion_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_MOTION) as *mut KineticEnergy;
18+
let mut stop_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_STOP) as *mut app::KineticEnergy;
19+
let mut gravity_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_GRAVITY) as *mut app::KineticEnergy;
20+
let mut motion_energy = KineticModule::get_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_MOTION) as *mut app::KineticEnergy;
2121

2222
let mut aerial_y_speed = 0.0;
2323
let mut aerial_x_speed = KineticModule::get_sum_speed_x(fighter.module_accessor, *KINETIC_ENERGY_RESERVE_ATTRIBUTE_MAIN) * start_spd_x_mul;
@@ -36,8 +36,8 @@ pub unsafe extern "C" fn special_s_init(fighter: &mut L2CFighterCommon) -> L2CVa
3636
// alStack208 = motion energy
3737
if [*FIGHTER_STATUS_KIND_SPECIAL_S, *FIGHTER_ROY_STATUS_KIND_SPECIAL_S2].contains(&current_status_kind) {
3838
if current_situation_kind == *SITUATION_KIND_GROUND {
39-
let reset_speed_2f = smash::phx::Vector2f { x: 0.0, y: 0.0 };
40-
let reset_speed_3f = smash::phx::Vector3f { x: 0.0, y: 0.0, z: 0.0 };
39+
let reset_speed_2f = Vector2f { x: 0.0, y: 0.0 };
40+
let reset_speed_3f = Vector3f { x: 0.0, y: 0.0, z: 0.0 };
4141
smash::app::lua_bind::KineticEnergy::reset_energy(motion_energy, *ENERGY_MOTION_RESET_TYPE_GROUND_TRANS_IGNORE_NORMAL, &reset_speed_2f, &reset_speed_3f, fighter.module_accessor);
4242
smash::app::lua_bind::KineticEnergy::enable(motion_energy);
4343
smash::app::lua_bind::KineticModule::unable_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_STOP);
@@ -52,9 +52,9 @@ pub unsafe extern "C" fn special_s_init(fighter: &mut L2CFighterCommon) -> L2CVa
5252
else{
5353
aerial_y_speed = 0.0;
5454
}
55-
let reset_speed_2f = smash::phx::Vector2f { x: aerial_x_speed, y: 0.0 };
56-
let reset_speed_gravity_2f = smash::phx::Vector2f { x: 0.0, y: aerial_y_speed };
57-
let reset_speed_3f = smash::phx::Vector3f { x: 0.0, y: 0.0, z: 0.0 };
55+
let reset_speed_2f = Vector2f { x: aerial_x_speed, y: 0.0 };
56+
let reset_speed_gravity_2f = Vector2f { x: 0.0, y: aerial_y_speed };
57+
let reset_speed_3f = Vector3f { x: 0.0, y: 0.0, z: 0.0 };
5858
smash::app::lua_bind::KineticEnergy::reset_energy(stop_energy, *ENERGY_STOP_RESET_TYPE_AIR, &reset_speed_2f, &reset_speed_3f, fighter.module_accessor);
5959
smash::app::lua_bind::KineticEnergy::reset_energy(gravity_energy, *ENERGY_GRAVITY_RESET_TYPE_GRAVITY, &reset_speed_gravity_2f, &reset_speed_3f, fighter.module_accessor);
6060
smash::app::lua_bind::KineticEnergy::enable(stop_energy);
@@ -64,16 +64,16 @@ pub unsafe extern "C" fn special_s_init(fighter: &mut L2CFighterCommon) -> L2CVa
6464
}
6565
if [*FIGHTER_ROY_STATUS_KIND_SPECIAL_S3, *FIGHTER_ROY_STATUS_KIND_SPECIAL_S4].contains(&current_status_kind) {
6666
if current_situation_kind == *SITUATION_KIND_GROUND {
67-
let reset_speed_2f = smash::phx::Vector2f { x: 0.0, y: 0.0 };
68-
let reset_speed_3f = smash::phx::Vector3f { x: 0.0, y: 0.0, z: 0.0 };
67+
let reset_speed_2f = Vector2f { x: 0.0, y: 0.0 };
68+
let reset_speed_3f = Vector3f { x: 0.0, y: 0.0, z: 0.0 };
6969
smash::app::lua_bind::KineticEnergy::reset_energy(motion_energy, *ENERGY_MOTION_RESET_TYPE_GROUND_TRANS_IGNORE_NORMAL, &reset_speed_2f, &reset_speed_3f, fighter.module_accessor);
7070
smash::app::lua_bind::KineticEnergy::enable(motion_energy);
7171
smash::app::lua_bind::KineticModule::unable_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_STOP);
7272
smash::app::lua_bind::KineticModule::unable_energy(fighter.module_accessor, *FIGHTER_KINETIC_ENERGY_ID_GRAVITY);
7373
}
7474
else if current_situation_kind == *SITUATION_KIND_AIR {
75-
let reset_speed_2f = smash::phx::Vector2f { x: 0.0, y: 0.0 };
76-
let reset_speed_3f = smash::phx::Vector3f { x: 0.0, y: 0.0, z: 0.0 };
75+
let reset_speed_2f = Vector2f { x: 0.0, y: 0.0 };
76+
let reset_speed_3f = Vector3f { x: 0.0, y: 0.0, z: 0.0 };
7777
smash::app::lua_bind::KineticEnergy::reset_energy(stop_energy, *ENERGY_STOP_RESET_TYPE_AIR, &reset_speed_2f, &reset_speed_3f, fighter.module_accessor);
7878
smash::app::lua_bind::KineticEnergy::reset_energy(gravity_energy, *ENERGY_GRAVITY_RESET_TYPE_GRAVITY, &reset_speed_2f, &reset_speed_3f, fighter.module_accessor);
7979
smash::app::lua_bind::KineticEnergy::enable(stop_energy);

fighters/common/src/function_hooks/aura.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,10 @@ pub unsafe extern "C" fn lucario_set_effect_scale(vtable: u64, fighter: &mut Fig
109109
let right = WorkModule::get_int(module_accessor, *FIGHTER_LUCARIO_INSTANCE_WORK_ID_INT_EF_ID_RHADOU) as u32;
110110
let scale = 0.0;
111111
if left != 0 {
112-
EffectModule::set_scale(module_accessor, left, &smash::phx::Vector3f{x: scale, y: scale, z: scale});
112+
EffectModule::set_scale(module_accessor, left, &Vector3f{x: scale, y: scale, z: scale});
113113
}
114114
if right != 0 {
115-
EffectModule::set_scale(module_accessor, right, &smash::phx::Vector3f{x: scale, y: scale, z: scale});
115+
EffectModule::set_scale(module_accessor, right, &Vector3f{x: scale, y: scale, z: scale});
116116
}
117117
}
118118
}

fighters/common/src/function_hooks/collision.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ unsafe fn groundcollision__processgroundcollisioninfo_check_landing(groundcollis
145145
}
146146
// Sets GroundCollisionLine
147147
#[skyline::hook(offset = 0x52d920)]
148-
unsafe fn groundcollision__processgroundcollisioninfo_check_landing_sub(groundcollision: u64, arg2: *mut u64, prev_ecb_bottom_pos: *mut smash::phx::Vector2f, ecb_bottom_translation: *mut smash::phx::Vector2f, arg5: u64, arg6: u64, arg7: *mut u64) -> *mut GroundCollisionLine {
148+
unsafe fn groundcollision__processgroundcollisioninfo_check_landing_sub(groundcollision: u64, arg2: *mut u64, prev_ecb_bottom_pos: *mut Vector2f, ecb_bottom_translation: *mut Vector2f, arg5: u64, arg6: u64, arg7: *mut u64) -> *mut GroundCollisionLine {
149149
if *((groundcollision + 0x39f) as *mut bool) {
150150
// Ignore ground collision
151151
return 0 as *mut GroundCollisionLine;

fighters/common/src/function_hooks/effect.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -326,7 +326,7 @@ unsafe fn DOWN_EFFECT_hook(lua_state: u64) {
326326
}
327327

328328
#[skyline::hook(replace=EffectModule::req_on_joint)]
329-
unsafe fn req_on_joint_hook(boma: &mut BattleObjectModuleAccessor, effHash: smash::phx::Hash40, boneHash: smash::phx::Hash40, pos: &smash::phx::Vector3f, rot: &smash::phx::Vector3f, size: f32, arg7: &smash::phx::Vector3f, arg8: &smash::phx::Vector3f, arg9: bool, arg10: u32, arg11: i32, arg12: i32) -> u64 {
329+
unsafe fn req_on_joint_hook(boma: &mut BattleObjectModuleAccessor, effHash: smash::phx::Hash40, boneHash: smash::phx::Hash40, pos: &Vector3f, rot: &Vector3f, size: f32, arg7: &Vector3f, arg8: &Vector3f, arg9: bool, arg10: u32, arg11: i32, arg12: i32) -> u64 {
330330
let mut eff_size = size;
331331
if SHOCKWAVE_FX.contains(&effHash.hash) {
332332
eff_size = size * 0.7;
@@ -335,7 +335,7 @@ unsafe fn req_on_joint_hook(boma: &mut BattleObjectModuleAccessor, effHash: smas
335335
}
336336

337337
#[skyline::hook(replace=EffectModule::req_follow)]
338-
unsafe fn req_follow(boma: &mut BattleObjectModuleAccessor, effHash: smash::phx::Hash40, boneHash: smash::phx::Hash40, pos: &smash::phx::Vector3f, rot: &smash::phx::Vector3f, size: f32, arg7: bool, arg8: u32, arg9: i32, arg10: i32, arg11: i32, arg12: i32, arg13: bool, arg14: bool) -> u64 {
338+
unsafe fn req_follow(boma: &mut BattleObjectModuleAccessor, effHash: smash::phx::Hash40, boneHash: smash::phx::Hash40, pos: &Vector3f, rot: &Vector3f, size: f32, arg7: bool, arg8: u32, arg9: i32, arg10: i32, arg11: i32, arg12: i32, arg13: bool, arg14: bool) -> u64 {
339339
let mut eff_size = size;
340340
// Shrink knockback smoke effect by 25%
341341
if effHash.hash == hash40("sys_flyroll_smoke") as u64 { // hash for kb smoke
@@ -363,7 +363,7 @@ unsafe fn preset_lifetime_rate_partial_hook(boma: &mut BattleObjectModuleAccesso
363363
}
364364

365365
#[skyline::hook(replace=EffectModule::get_dead_effect_scale)]
366-
unsafe fn get_dead_effect_scale_hook(boma: &mut BattleObjectModuleAccessor, arg1: &smash::phx::Vector3f, arg2: f32, arg3: bool) -> f32 {
366+
unsafe fn get_dead_effect_scale_hook(boma: &mut BattleObjectModuleAccessor, arg1: &Vector3f, arg2: f32, arg3: bool) -> f32 {
367367
// Shrink KO gfx by 25%
368368
original!()(boma, arg1, arg2, arg3) * 0.75
369369
}

0 commit comments

Comments
 (0)