Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mario/Doc Aesthetic Tweaks #2308

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Mario/Doc Aesthetic Tweaks #2308

merged 4 commits into from
Mar 19, 2024

Conversation

4Lukaska
Copy link
Contributor

@4Lukaska 4Lukaska commented Mar 9, 2024 •
edited
Loading

Assets: Assets.zip

Will post better images/videos later

CHANGELOG

MARIO

JAB

  • [$] Adjusted VFX postion/timing to match Doc's (all hits)

UPSMASH

  • [$] Shrunk VFX a bit so that the arc is slightly closer to Mario's head

DTHROW

  • [$] Adjusted animation so that Mario spins in the air after releasing the opponent (similar to how the move looked in previous games)
Mario.mp4

DR. MARIO

GENERAL

  • [$] Will now always vocalize when jumping instead of playing the usual jump SFX, similar to how he does it in Melee/PM (includes walljump and ledgejump too)

JAB

  • [$] Recolored VFX (all hits)

Jab 1:
IMG_6398
Jab 2:
IMG_6397
Jab 3:
IMG_6396

FTILT

  • [$] Recolored VFX (all angles)

IMG_6395

UPTILT

  • [$] Recolored VFX

IMG_6393

DTILT

  • [$] Recolored VFX

IMG_6394

FSMASH

  • [$] Adjusted smash attack spark position and added a VFX streak at Doc's arm to match Mario's (all angles)

Arm:

  • [$] Effect Type: Electric > Normal (all angles)
  • [/] Hitlag Multiplier: 0.8x > 1.0x (all angles)

IMG_6390

UPSMASH
Late:

  • [$] Hit SFX Type (Ground): Heavy > Kick

FAIR

  • [$] Brightened arc VFX

UPAIR

  • [$] Recolored VFX
  • [$] Adjusted animation to match Mario's up air

IMG_6391

UP SPECIAL

  • [$] Recolored VFX

IMG_6433

DTHROW

  • [$] Adjusted animation so that Doc spins in the air after releasing the opponent (similar to how the move looked in previous games)
Doc.mp4

HOOH

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 9, 2024 •
edited
Loading

Download the artifacts for this pull request:

@moklmaru moklmaru added aesthetics Animation, sound, or effect changes semver:patch includes assets discussion ongoing Content has yet to be agreed upon labels Mar 10, 2024
4Lukaska added 3 commits March 10, 2024 14:42
@4Lukaska
sourspot fsmash hitlag increase
e870bd0
@4Lukaska
move fsmash flash effect
ad83a27
@4Lukaska
fixes and additions
3452291 
- Changed coloring to apply from the fighter_param file rather than ACMD scripts
- Mario jab VFX adjustments
- Recolored up special VFX
- Slightly tweaked uptilt effect coloring
- Fixed new animations not playing on non-default alts (oops)
@WuBoytH WuBoytH removed the discussion ongoing Content has yet to be agreed upon label Mar 19, 2024
@WuBoytH WuBoytH merged commit bb03551 into HDR-Development:dev Mar 19, 2024
2 of 3 checks passed
@4Lukaska 4Lukaska deleted the Mario-Visuals branch March 19, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
aesthetics Animation, sound, or effect changes includes assets semver:patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@4Lukaska @moklmaru @WuBoytH