Skip to content

Commit 45909b9

Browse files
committed
fix(types): set compatibility with puppeteer v10
resolve #33
1 parent d3adbbd commit 45909b9

File tree

4 files changed

+58
-39
lines changed

4 files changed

+58
-39
lines changed

.github/workflows/node.js.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,10 @@ jobs:
3131
version: '7'
3232
- library: 'puppeteer'
3333
version: '8'
34+
- library: 'puppeteer'
35+
version: '9'
36+
- library: 'puppeteer'
37+
version: '10'
3438
- library: 'playwright'
3539
version: '1.10'
3640
steps:

package-lock.json

Lines changed: 52 additions & 37 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@
3535
"playwright": "^1.10.0",
3636
"prettier": "^2.0.5",
3737
"pretty-quick": "^1.10.0",
38-
"puppeteer": "^8.0.0",
38+
"puppeteer": "^10.0.0",
3939
"semantic-release": "^17.0.7",
4040
"ts-jest": "^24.0.1",
4141
"typescript": "^3.8.3"

src/controllers/PuppeteerController.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export interface PuppeteerRequest {
7373
url(): string;
7474
} | null;
7575
headers(): Record<string, string>;
76-
method(): 'GET' | 'POST' | 'PATCH' | 'PUT' | 'DELETE' | 'OPTIONS';
76+
method(): string;
7777
postData(): string | undefined;
7878
resourceType():
7979
| 'document'

0 commit comments

Comments
 (0)