🎨🔨 Re-adjust the height of TimePicker on Calendar resize due to number of days #5539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cker pass Related Commit: 70179e9 Related issue: Hacker0x01#5466
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5539 +/- ##
==========================================
+ Coverage 96.99% 97.01% +0.02%
==========================================
Files 30 30
Lines 3323 3350 +27
Branches 1410 1412 +2
==========================================
+ Hits 3223 3250 +27
Misses 98 98
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5466
Description
As mentioned in the ticket, the Time Picker height is not getting updated when we switch between months, so sometimes when we switch from 30 days month to 31 days month and vice a versa, we have some UI-issues. I added a Resize-Observer and update the time picker height whenever calendar popup height changes and updated the test cases for it.
Contribution checklist