Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IDN domain names #23

Open
yusefren opened this issue Apr 24, 2023 · 1 comment
Open

Support for IDN domain names #23

yusefren opened this issue Apr 24, 2023 · 1 comment

Comments

@yusefren
Copy link

IDN domain names should be supported
i❤️.ws is valid and working domain
بريد@موقع.شبكة should be valid email address

@troyhunt
Copy link
Contributor

Hey @yusefren, thanks very much for adding this. I've just committed 2 failing tests for this in 6944aa8.

That said (and for anyone that wants to take a stab at implementing this), we're talking about extremely rare edge cases here in terms of the email addresses I see in data breaches. I suspect that anyone attempting to use one of these addresses on most sites would find them rejected and I'd be surprised if they were in broad use. By all means, implement this idea just make sure it doesn't hit the performance of parsing out the most common stuff.

troyhunt added a commit that referenced this issue Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants