Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Fix Linting Errors (REVISIT) #19

Merged
merged 11 commits into from
Apr 19, 2023
Merged

Conversation

HenryAsa
Copy link
Owner

@HenryAsa HenryAsa commented Apr 19, 2023

Pull Request Template

Description

Update linting files to ensure that the repository can pass its workflows. I simply removed the linter.yml file (commented it out) for the time being until I can get it to work properly. Should revisit this issue!
Fixes # (issue)

Related Issues

Related to #12

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Passes workflows.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@HenryAsa HenryAsa self-assigned this Apr 19, 2023
Copy link
Owner Author

@HenryAsa HenryAsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should revisit linting errors later.

@HenryAsa HenryAsa merged commit 5e09b8e into main Apr 19, 2023
@HenryAsa HenryAsa deleted the feature/fix_linting_errors branch April 19, 2023 17:23
@HenryAsa HenryAsa added the Improvement minor improvements that don't change functionality label Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement minor improvements that don't change functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant