Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use amre::removeInvalidParticles for the Beam #1067

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Feb 13, 2024

Use the new amrex::removeInvalidParticles and amrex::partitionParticles to use less memory in shiftSlippedParticles.
Additionally, this allows shiftSlippedParticles to work with runtime components.

In a test, the new version of shiftSlippedParticles was slightly faster and reduced its memory usage from 373 MiB to 7 MiB.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the cleaning Code cleaning, avoid duplication, better naming, better style etc. label Feb 13, 2024
@AlexanderSinn AlexanderSinn mentioned this pull request Feb 21, 2024
9 tasks
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@MaxThevenet MaxThevenet merged commit 4a257f4 into Hi-PACE:development Feb 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleaning Code cleaning, avoid duplication, better naming, better style etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants