Fix MPI buffer max_leading_slices #1079
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noticed by @huixingjian, the
hipace.comms_buffer_max_leading_slices
option doesn't work sometimes. This is because there was one slice where incoming metadata could be received too early, if theIsend
of the same slice would happen instantly. Furthermore, I noticed that in some situations (all ranks compute slices faster or at the same speed as the head rank) it is possible to go into a deadlock where none of the leading slices are filled, so I adjusted the assert and documentation to only include the trailing slices.const
isconst
)