Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct the direction of the spatial rotation #1091

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

huixingjian
Copy link
Contributor

@huixingjian huixingjian commented Apr 3, 2024

This PR is to correct a mistake I made on PR #1057 . The rotation of the spatial distribution of the pulse and the propagating direction weren't in consistency. And this is now fixed.
Screenshot 2024-04-03 at 17 34 30

Copy link
Member

@AlexanderSinn AlexanderSinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@AlexanderSinn AlexanderSinn added bug Something isn't working component: laser envelope About the laser envelope solver labels Apr 3, 2024
Copy link
Member

@MaxThevenet MaxThevenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@MaxThevenet MaxThevenet merged commit dff31c1 into Hi-PACE:development Apr 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: laser envelope About the laser envelope solver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants