Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove invalid beam particle from first diagnostic step #1200

Conversation

AlexanderSinn
Copy link
Member

@AlexanderSinn AlexanderSinn commented Jan 29, 2025

When using a Gaussian fixed_weight beam with zmin and zmax, the particles outside the zmin and zmax range would be initialized as invalid particles. Outputting the beam in the first time step these would still be in the output (but not in the subsequent steps). When reading the file into another simulation, it would look like zmin and zmax was ignored.

  • Small enough (< few 100s of lines), otherwise it should probably be split into smaller PRs
  • Tested (describe the tests in the PR description)
  • Runs on GPU (basic: the code compiles and run well with the new module)
  • Contains an automated test (checksum and/or comparison with theory)
  • Documented: all elements (classes and their members, functions, namespaces, etc.) are documented
  • Constified (All that can be const is const)
  • Code is clean (no unwanted comments, )
  • Style and code conventions are respected at the bottom of https://github.com/Hi-PACE/hipace
  • Proper label and GitHub project, if applicable

@AlexanderSinn AlexanderSinn added the bug Something isn't working label Jan 29, 2025
@AlexanderSinn AlexanderSinn added the component: beam About the beam species label Feb 6, 2025
@MaxThevenet MaxThevenet merged commit cf5abf8 into Hi-PACE:development Feb 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: beam About the beam species
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants