Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/info: only display keg info if tap matches #19295

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cmd/info: only display keg info if tap matches #19295

wants to merge 2 commits into from
+1 −1

Conversation

ZhongRuoyu
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Fixes #19294.

Bo98
Bo98 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@Bo98 Bo98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine though do we want to handle the case where a tab tap is nil any differently?

ZhongRuoyu
ZhongRuoyu commented Feb 13, 2025
View reviewed changes
Library/Homebrew/cmd/info.rb Outdated
@@ -298,7 +298,7 @@ def info_formula(formula)
kegs = [
*heads.sort_by { |keg| -keg.tab.time.to_i },
*versioned.sort_by(&:scheme_and_version),
]
].select { |keg| keg.tab.tap == formula.tap }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine though do we want to handle the case where a tab tap is nil any differently?

Not sure when that'll happen, but I guess we can do something like this in case it ever does:

Suggested change
].select { |keg| keg.tab.tap == formula.tap }
].select { |keg| (tap = keg.tab.tap).nil? || tap == formula.tap }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bo98 Bo98 Bo98 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Brew info reports a formula installed that is not installed
2 participants
@ZhongRuoyu @Bo98