WIP: create lightweight internal JSON API #19241
Draft
+43
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
reviewed
Feb 5, 2025
| hash = { | ||
| "name" => name, | ||
| "pkg_version" => pkg_version.to_s, | ||
| "sha256" => bottle_hash["files"][bottle_tag.to_sym]&.fetch("sha256"), |
There was a problem hiding this comment.
Could slim things even more and consider not setting this key at all unless we have a non-nil sha256 (pulling this into an if below)
There was a problem hiding this comment.
Agreed, makes sense! I figured I might do some testing to see if doing an array instead of a hash is significantly better, too. I wasn't sure whether, once gzipped, that would make a huge difference or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts to create a new internal API per #19204. These files are sharded by OS/arch, and contain the tap's formula renames, tap migrations, etc. The only information it contains about each individual formula is the name,
pkg_version, and bottle hash.Known to-dos (just for my own notes, some of these will probably end up being in separate PRs):
This PR is a work-in-progress, I'm just uploading it so other people can mess around with the code I started to write at the AGM. Anyone, please feel free to push commits or supercede this PR!