Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install size #19254

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Install size #19254

wants to merge 19 commits into from

Conversation

tyuwags
Copy link

@tyuwags tyuwags commented Feb 6, 2025

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

resolve #18373

As discussed in the issue, these changes add the --ask option and the HOMEBREW_ASK environment variable to display the packages and dependencies that will be installed, along with their sizes, and prompt the user for input.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tyuwags, great work so far!

Library/Homebrew/cmd/install.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/install.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/install.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/install.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/install.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/install.rb Outdated Show resolved Hide resolved
Library/Homebrew/cmd/install.rb Outdated Show resolved Hide resolved
@tyuwags tyuwags marked this pull request as draft February 11, 2025 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

brew install should display download size
2 participants