Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eid-klient 5.0 (new cask) #201164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

eid-klient 5.0 (new cask) #201164

wants to merge 1 commit into from

Conversation

kiblik
Copy link
Contributor

@kiblik kiblik commented Feb 10, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@daeho-ro daeho-ro changed the title Add eid-sk eid-sk 5.0 (new cask) Feb 11, 2025
Casks/e/eid-sk.rb Outdated Show resolved Hide resolved
Casks/e/eid-sk.rb Outdated Show resolved Hide resolved
@kiblik kiblik changed the title eid-sk 5.0 (new cask) eid-klient 5.0 (new cask) Feb 11, 2025
@kiblik kiblik requested a review from bevanjkay February 11, 2025 14:17
Casks/e/eid-klient.rb Outdated Show resolved Hide resolved
@daeho-ro
Copy link
Member

Can you squash your commits with the message like this PR title?

Copy link
Member

@bevanjkay bevanjkay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this isn't actually signed and notarized. I'm not sure why this isn't failing the audit on CI, but it doesn't currently meet the requirements to be included in homebrew-cask.

Screenshot 2025-02-13 at 10 04 52 am

Sorry this wasn't detected earlier @kiblik

@kiblik
Copy link
Contributor Author

kiblik commented Feb 12, 2025

It looks like this isn't actually signed and notarized. I'm not sure why this isn't failing the audit on CI, but it doesn't currently meet the requirements to be included in homebrew-cask.

Sorry this wasn't detected earlier @kiblik

NP @bevanjkay. I'm just not sure what I will be able to do with it. But I will try to reach the responsible team.
Can I ask, how you generate the mentioned report? To be able to replicate it.

@bevanjkay
Copy link
Member

I used an app called Apparency. It also required me to override the security warning to run it locally on a Silicon (M1) MacBook

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants