Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jameica 2.10.5 #201229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

jameica 2.10.5 #201229

wants to merge 1 commit into from

Conversation

zyoshoka
Copy link
Contributor

Created by brew bump


Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Feb 11, 2025
@zyoshoka zyoshoka force-pushed the bump-jameica-2.10.5 branch from 20fd8b4 to b29c6fb Compare February 11, 2025 12:22
@zyoshoka zyoshoka force-pushed the bump-jameica-2.10.5 branch from b29c6fb to c7f40be Compare February 11, 2025 12:59
@@ -12,7 +15,7 @@
regex(%r{href=.*?/jameica[._-]macos64[._-]v?(\d+(?:\.\d+)+)\.zip}i)
end

app "jameica.app"
artifact "jameica.app", target: "#{appdir}/jameica.app"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain workaround?
If the application is broken, then it should be fixed upstream.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

audit_rosetta assumes that app contains at least one binary in the Contents/MacOS directory, which this app does not. Since this audit was introduced relatively recently, it was not caught in previous updates, and I don't think the app is broken.

I used the similar approach in #201001.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we just add a comment explaining that above the stanza?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-cask-pr PR was created using `brew bump-cask-pr`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants