-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go 1.24.0, go@1.23 1.23.6 (new formula) #201070
Merged
Merged
+116
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fd80d19
to
a57226c
Compare
This was referenced Dec 14, 2024
This was referenced Jan 15, 2025
stefanb
added a commit
that referenced
this pull request
Jan 20, 2025
Test failure found in #201070: https://github.com/Homebrew/homebrew-core/actions/runs/12819119607/job/35747580107?pr=201070#step:3:3879 ```` Error: certgraph: failed An exception occurred within a child process: Minitest::Assertion: Expected /www\.example\.edu/ to match "example.com\n". ````
chenrui333
approved these changes
Feb 12, 2025
This was referenced Feb 12, 2025
6 tasks
Looking at the current CI failures indicates to me that we should just merge this PR when it finishes. We can collect the list of failures and follow up afterward. |
This was referenced Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
automerge-skip
`brew pr-automerge` will skip this pull request
CI-build-dependents-from-source
Pass --build-dependents-from-source to brew test-bot.
CI-no-fail-fast
Continue CI tests despite failing GitHub Actions matrix builds.
CI-no-fail-fast-deps
Continue dependent tests despite failing GitHub Actions matrix tests.
CI-published-bottle-commits
The commits for the built bottles have been pushed to the PR branch.
CI-skip-recursive-dependents
Pass --skip-recursive-dependents to brew test-bot.
in progress
Stale bot should stay away
long dependent tests
Set a long timeout for dependent testing
new formula
PR adds a new formula to Homebrew/homebrew-core
no long build conflict
Do not allow merging other pull requests when files conflict with this one
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Announcements:
Release notes:
Go 1.24 milestone:
(release blockers, commits, PRs)
Go release dashboard: https://dev.golang.org/release
Downloads: https://go.dev/dl/
Related previous:
Related upstream:
Builds:
Problematic dependant formulae:
Could not resolve host: ghcr.io
Could not resolve host: ghcr.io
Expected /github\.com/ to match "".
internal error: package "fmt" without types was imported from "github.com/aws/aws-sdk-go/aws/client"
[Bug] Build fails with Go 1.24 eksctl-io/eksctl#8209 eksctl: pin to go@1.23 (go 1.24) #207446 Update building with golang 1.24 eksctl-io/eksctl#8210 eksctl: simplify binary build #207468github.com/supranational/blst/bindings/go /Users/brew/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/supranational/blst@v0.3.13/bindings/go/blst.go:237:11: cannot define new methods on non-local type SecretKey
Build fails with Go 1.24 ethereum/go-ethereum#31072 & upstream:
➡️ ethereum: pin to go@1.23 (go 1.24) #207290
go.mod: update blst for compatibility with Go 1.24 ethereum/go-ethereum#31165
Go version "go1.24rc1" is too new; Go linker patches aren't available for go1.24 or later yet
garble go1.24 patches burrowers/go-patches#8 https://github.com/burrowers/garble/releases/tag/v0.14.1 garble 0.14.1 #207392 garble: revision bump (go 1.24) #207417API rate limit exceeded
Minitest::Assertion: Expected /sloppyLen:\ len\(str\)\ <=\ 0\ can\ be\ len\(str\)\ ==\ 0/ to match "internal error: package \"fmt\" without types was imported from \"command-line-arguments\"\n".
deps: bump x/tools to 0.30.0 to support Go 1.24 go-critic/go-critic#1454 go-critic 0.12.0 #207408 go-critic: revision bump (go 1.24) #207418govulncheck: Loading packages failed, possibly due to a mismatch between the Go version used to build govulncheck and the Go version on PATH. Consider rebuilding govulncheck with the current Go version.
➡️ revision bump as in govulncheck: build with go1.23 #181468genericNodeError
?jobfile/run_rec_server.go:55:29: non-constant format string in call to (*log.Logger).Printf jobfile/run_log_test.go:106:18: non-constant format string in call to (*testing.common).Logf
/opt/homebrew/Cellar/kubefirst/2.8.2/bin/kubefirst version kubefirst-cli golang utility version: v2.8.2 Error: kubefirst: failed An exception occurred within a child process: Minitest::Assertion: Expected /2\.8\.2/ to match "".
kubefirst 2.8.3 #207344 kubefirst: revision bump (go 1.24) #207518package requires newer Go version go1.24 (application built with go1.23)
Go 1.24 support goplus/llgo#973 llgo: revision bump (go 1.24) #207420unexpected token at '{"code":"compile","severity":"er'
staticcheck: Fails with Go 1.24: internal error in importing ... (unsupported version: 2) dominikh/go-tools#1627 https://github.com/dominikh/go-tools/releases/tag/2025.1 staticcheck 2025.1 #207350 ➡️ staticcheck: revision bump (go 1.24) #207419internal error: package "log" without types was imported from "github.com/russellcardullo/terraform-provider-pingdom/pingdom [github.com/russellcardullo/terraform-provider-pingdom/pingdom.test]"
Build fails with Go 1.24 bflad/tfproviderlint#325 tfproviderlint: pin to go@1.23 (go 1.24) #207449 tfproviderlint 0.31.0 #207490 tfproviderlint: revision bump (go 1.24) #207511# github.com/trezor/trezord-go/usb/lowlevel/libusb usb/lowlevel/libusb/libusb.go:408:10: cannot define new methods on non-local type Struct_Libusb_Endpoint_Descriptor ...
Release a version built with supported Go version trezor/trezord-go#301 Update go to latest trezor/trezord-go#302 Build fails with Go 1.24 trezor/trezord-go#303 ➡️ trezor-bridge: pin to go@1.23 (go 1.24) #207185 or deprecate because unmaintainedHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?