lume 0.1.6 (new formula)

[unitof]

Need to write a good test then confirm everything is working.

Test should do more than print version: https://github.com/trycua/homebrew-lume/blob/main/Formula/lume.rb

Gotta run to another project now but pushing so work doesn't conflict with someone else. Feel free to contribute though! I'm slow but love learning by writing Homebrew formulae.

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[unitof]

I'd love the test to actually pull and run an image but the current smallest (Ubuntu) on the default registry is 20GB.

Seems excessive for a test. Or legitimate considering what this app does (pull and run prebuilt VMs).

Could use some guidance.

Meanwhile, made the test just do a different command which confirms installation (get the current machine's latest IPSW image URL).

[gromgit]

In general, I think tests that catch expected failures are also OK, as long as they exercise non-trivial parts of the code (printing a version number or help text is as trivial as it gets).

For instance, see #206363 (full disclosure: that was my PR). The version check was to verify that the manual version setting in the install block actually happened (this Is fairly common amongst Go formulae), but the real "meat" is the "terminal not cursor addressable" test, because the test block is run with TERM=dumb but lazysql is an SQL TUI.

[gromgit]

Strangely, my view of your PR looks like this:

so I can't make any concrete suggestions.

[unitof]

Yeah…I'm realizing the same. Playing with a new Git client (Working Copy) and seems to have messed up the amend. Please hold!

[unitof]

Would appreciate an exception to GitHub repository too new (<30 days old) from maintainers.

[unitof]

The '%{http_code}' is a string arg for curl for the test stanza. How can I annotated it correctly so it doesn't trigger Style/FormatStringToken: Prefer annotated tokens (like %<foo>s) over template tokens (like %{foo}).?

[alebcay]

I don't have a good answer for allowing the exact use of %{http_code}, but you could consider a slightly different curl invocation, e.g. curl -sI localhost:#{port}/lume, and then check the first line of the output, e.g.:

assert_match /HTTP.*\w+[200|404]/, shell_output("curl -sI localhost:#{port}/lume").lines.first

(-I uses the HTTP HEAD method; if it is crucial to use GET instead, -I can be replaced with -i instead, it will just produce and discard more output.)