vfkit v0.6.0 (new formula) #207385
Open
vfkit v0.6.0 (new formula) #207385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
go
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
github-actions
bot
added
the
autosquash
github-actions
bot
removed
the
autosquash
vyasgun
force-pushed
the
vfkit-0.6.0
branch
3 times, most recently
from
65dd3ec to
c512718
Compare
SMillerDev
reviewed
Feb 12, 2025
SMillerDev
reviewed
Feb 13, 2025
Comment on lines
+20
to
+22
| # test version | ||
| version_output = shell_output("#{bin}/vfkit --version 2>&1").strip | ||
| assert_match(/vfkit version: v#{version}/, version_output) |
There was a problem hiding this comment.
Suggested change
| # test version | |
| version_output = shell_output("#{bin}/vfkit --version 2>&1").strip | |
| assert_match(/vfkit version: v#{version}/, version_output) | |
| version_output = shell_output("#{bin}/vfkit --version 2>&1") | |
| assert_match("vfkit version: v#{version}", version_output) |
Comment on lines
+25
to
+27
| lines = shell_output("#{bin}/vfkit --kernel foo --initrd bar " \ | ||
| "--kernel-cmdline baz 2>&1", 1).strip.split(/\r?\n|\r/) | ||
| assert_match(/foo: no such file or directory/, lines.last) |
There was a problem hiding this comment.
Suggested change
| lines = shell_output("#{bin}/vfkit --kernel foo --initrd bar " \ | |
| "--kernel-cmdline baz 2>&1", 1).strip.split(/\r?\n|\r/) | |
| assert_match(/foo: no such file or directory/, lines.last) | |
| output = shell_output("#{bin}/vfkit --kernel foo --initrd bar " \ | |
| "--kernel-cmdline baz 2>&1", 1) | |
| assert_match("foo: no such file or directory", output) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?