Code refactor, performance improvements, internalizing types in AppControl Manager #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# What's New * Improved the file and folder picker experience by remembering the last used path when selecting multiple files/folders. * Sealed and internalized many methods and classes, reducing the public API surface area, improving security and performance. * Refactored multiple sections in the code. * Made it obvious in the project file which packages are primary and which ones are transitive. * All of the changes made in this PR resulted in noticeable reduction in the app package size.
There was a problem hiding this comment.
PR Overview
This PR refactors several components of the AppControl Manager by internalizing numerous types and methods while also making formatting and access modifier improvements. Key changes include:
- Internalizing public classes, methods, and properties to reduce the public API surface area.
- Adding event subscription for UnobservedTaskException and refining exception handling in the UI.
- Refactoring code formatting and consistency across multiple files.
Reviewed Changes
| File | Description |
|---|---|
| App.xaml.cs | Added subscription for UnobservedTaskException and commented out FirstChanceException subscription for future use. |
| CustomUIElements/CustomPatternBasedFilePath.xaml.cs | Changed field modifiers from public to internal. |
| IntelGathering/FileIdentity.cs | Updated class and member access to internal. |
| IntelGathering/FileSignerInfo.cs | Updated class and member access to internal. |
| IntelGathering/KernelUserVerdict.cs | Updated required properties to internal. |
| IntelGathering/FileIdentityECCBasedHashSet.cs | Changed constructor and member access to internal. |
| IntelGathering/OptimizeMDECSVData.cs | Changed Optimize method access from public to internal. |
| IntelGathering/FileIdentitySignatureBasedHashSet.cs | Changed constructor and member access to internal. |
| IntelGathering/FileIdentityTimeBasedHashSet.cs | Changed constructor and member access to internal. |
| IntelGathering/EventAction.cs | Changed enum access from public to internal. |
| IntelGathering/KernelModeDrivers.cs | Updated struct members to internal. |
| IntelGathering/FileIdentityOrigin.cs | Changed enum access from public to internal. |
| IntelGathering/GetEventLogsData.cs | Modified control flow and access modifiers for event log processing methods. |
| IntelGathering/ScanLevels.cs | Changed enum access to internal. |
| IntelGathering/LocalFilesScan.cs | Minor cleanup of redundant newlines. |
| IntelGathering/FileSignerInfoComparer.cs | Changed class access to internal. |
| IntelGathering/PrepareEmptyPolicy.cs | Changed method access to internal. |
| IntelGathering/FileIdentityComparer.cs | Changed class access to internal. |
| IntelGathering/MDEAdvancedHuntingData.cs | Changed JSON converters from public to internal and maintained serialization logic. |
Copilot reviewed 64 out of 64 changed files in this pull request and generated no comments.
Added progress ring to the auto driver detection in the Create Supplemental Policy page. Security catalogs scan results are now cached, improving performance and speed of various features that rely on it. Also exposed a new option in the Settings page that lets you turn off/on this feature. It is enabled by default. more performance improvements
HotCakeX
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New
Improved the file and folder picker experience by remembering the last used path when selecting multiple files/folders.
Sealed and internalized many methods and classes, reducing the public API surface area, improving security and performance.
Refactored multiple sections in the code.
Made it obvious in the project file which packages are primary and which ones are transitive.
Added progress ring to the auto driver detection in the Create Supplemental Policy page.
Security catalogs scan results are now cached, improving performance and speed of various features that rely on it such as local file scans and simulation. Also exposed a new option in the Settings page that lets you turn off/on this feature. It is enabled by default.
Areas where performance has been significantly improved by this PR: Local file scans, Simulation, Logging. The improvements are propagated to other interconnected components throughout the app.