Skip to content
This repository was archived by the owner on Jun 15, 2021. It is now read-only.

Should logger affect the way log works? #3

Open
pamelin opened this issue May 10, 2018 · 0 comments
Open

Should logger affect the way log works? #3

pamelin opened this issue May 10, 2018 · 0 comments
Labels
bug Something isn't working

Comments

@pamelin
Copy link
Contributor

pamelin commented May 10, 2018

Logger seems to affect the way go's log works and redirects output to the default output which is Stdout. Default output for log is Stderr. There are couple of questions:

  • Should logger affect how other packages work?
  • If Yes should user be given option to disable this behaviour?
  • Should default for logger be Stdout? Stderr seems to be more appropriate output stream
  • We should have an option to silence initial log messages. Ideally they should use logger framework and not go's log

The way it works now affect how other can integrate with flyte. For example when you are trying to use flyte as dependency in your project logger package will be imported and init method will be executed and might result in unpredictable behaviour of log package or not gonna allow to silence logs for output.

@pamelin pamelin added invalid This doesn't seem right bug Something isn't working and removed invalid This doesn't seem right labels May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant