-
Notifications
You must be signed in to change notification settings - Fork 2.7k
feat: OPTIC-1733: Standardize Dropdown Components Using LSE selector #7257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e try to spread its values
…s/label-studio into fb-optic-1748/ui-improvements
…1748/ui-improvements" This reverts commit 233340c.
… + added intent delay
yyassi-heartex
commented
Apr 17, 2025
bmartel
approved these changes
Apr 17, 2025
/fm sync |
…tudio into fb-optic-1733/select
Contributor
Author
/git merge develop
|
/fm sync |
Contributor
Author
/git merge
|
All feedback was addressed exactly as suggested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New unified Select component

This pull request primarily focuses on replacing existing
Select
components with theSelect
component from the@humansignal/ui
library across multiple files. Additionally, it includes some refactoring and enhancements to improve code readability and functionality. Below are the most important changes:UI Component Updates:
Select
components withSelect
from@humansignal/ui
in various files, includingSelect.jsx
,Pagination.tsx
,Config.jsx
,CreateProject.jsx
,GeneralSettings.jsx
,Forms.jsx
,StorageForm.jsx
,SampleDatasetSelect.tsx
,ModelVersionSelector.jsx
, andSelect.jsx
in thedatamanager
directory. [1] [2] [3] [4] [5] [6] [7] [8] Fbb5e0ebL1, [9]Functional Enhancements:
Select
components to use the newonChange
signature provided by@humansignal/ui
, replacing the previous event-based handlers. [1] [2] [3] [4] [5] [6]Code Refactoring:
useMemo
hooks to optimize the computation of options forSelect
components, ensuring better performance and readability. [1] [2] [3]CSS and Layout Adjustments:
Select
component layout, including changes inuikit.css
to usedisplay: flex
instead ofdisplay: block
.Miscellaneous:
These changes collectively enhance the consistency and maintainability of the codebase by standardizing the use of the
Select
component from@humansignal/ui
and optimizing related code.