Skip to content

fix: FIT-136: Duration field at Info panel is not optimized for Dark mode #7623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 26, 2025

Conversation

yyassi-heartex
Copy link
Contributor

@yyassi-heartex yyassi-heartex commented May 26, 2025

This pull request updates the styling of the TimelineRegionEditor component to improve consistency and accessibility. The changes include replacing hardcoded color variables with standardized design tokens and enhancing the behavior of read-only input fields.

after update light mode
image

after update dark mode
image

Styling updates:

  • Replaced --sand_300 and --sand_100 with standardized design tokens --color-neutral-border for border and background colors to ensure consistency across the application.

Behavior enhancements:

  • Updated read-only input fields to include a cursor: default property and removed the focus outline for better user experience.

Copy link

netlify bot commented May 26, 2025

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 64b5b35
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/683461951804f300089fcc8e

Copy link

netlify bot commented May 26, 2025

Deploy Preview for label-studio-playground ready!

Name Link
🔨 Latest commit 64b5b35
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/68346195ea57c800081db15e
😎 Deploy Preview https://deploy-preview-7623--label-studio-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented May 26, 2025

Deploy Preview for label-studio-storybook ready!

Name Link
🔨 Latest commit 64b5b35
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/68346195c79ac80008794e89
😎 Deploy Preview https://deploy-preview-7623--label-studio-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@yyassi-heartex yyassi-heartex requested a review from a team May 26, 2025 09:57
@github-actions github-actions bot added the fix label May 26, 2025
Copy link

netlify bot commented May 26, 2025

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit 64b5b35
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/683461958157740008691617

@yyassi-heartex
Copy link
Contributor Author

yyassi-heartex commented May 26, 2025

/git merge

Workflow run
Successfully merged: 10 files changed, 22 insertions(+), 9 deletions(-)

yyassi-heartex and others added 2 commits May 26, 2025 12:22
@yyassi-heartex yyassi-heartex requested a review from bmartel May 26, 2025 12:42
@yyassi-heartex yyassi-heartex merged commit 0c50680 into develop May 26, 2025
45 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-fit-136/darkmode branch May 26, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants