Skip to content

fix: BROS-38: Fix sentry issue (i.map is not a function) +1 more #7662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 30, 2025

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented May 30, 2025

Two sentry issues are fixed here:

  1. Very often one with comments sdk. Fetch can return null and this case was not handled in comments sdk.
    TypeError: i.map is not a function

  2. Rare, but with app crash and easy to fix. OutlinerTree can't process regions list and crashes the app.
    This happens when region list has groupping by label and there is a region with no label.
    Empty labels should be fixed properly later, but the case is rare and we are fixing app crash here.
    Cannot read properties of undefined (reading 'locked')

hlomzik added 3 commits May 30, 2025 12:46
Fetch can return null and this case was not handled in comments sdk.
OutlinerTree can't process regions list and crashes the app.
This happens when region list has groupping by label and there is
a region with no label.
Empty labels should be fixed properly later, but the case is rare
and we are fixing app crash here.
Error when user tries to expand "No Label" group
@hlomzik hlomzik requested review from a team, Gondragos and nick-skriabin as code owners May 30, 2025 12:03
Copy link

netlify bot commented May 30, 2025

Deploy Preview for label-studio-docs-new-theme ready!

Name Link
🔨 Latest commit ef864ce
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-docs-new-theme/deploys/6839e355a3e57900085fd7b9
😎 Deploy Preview https://deploy-preview-7662--label-studio-docs-new-theme.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

netlify bot commented May 30, 2025

Deploy Preview for label-studio-playground canceled.

Name Link
🔨 Latest commit ef864ce
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-playground/deploys/6839e3554f73860008be56f3

Copy link

netlify bot commented May 30, 2025

Deploy Preview for label-studio-storybook canceled.

Name Link
🔨 Latest commit ef864ce
🔍 Latest deploy log https://app.netlify.com/projects/label-studio-storybook/deploys/6839e3553cf425000900e3e0

Copy link

netlify bot commented May 30, 2025

Deploy Preview for heartex-docs ready!

Name Link
🔨 Latest commit ef864ce
🔍 Latest deploy log https://app.netlify.com/projects/heartex-docs/deploys/6839e3553327de00080de8b5
😎 Deploy Preview https://deploy-preview-7662--heartex-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@hlomzik hlomzik changed the title Fb bros 38/sentry issues fix: BROS-38: Fix sentry issue (i.map is not a function) +1 more May 30, 2025
@hlomzik hlomzik requested a review from yyassi-heartex May 30, 2025 12:06
@hlomzik
Copy link
Collaborator Author

hlomzik commented May 30, 2025

/git merge

Workflow run
Error: Workflow failed

@nikitabelonogov
Copy link
Member

nikitabelonogov commented May 30, 2025

/git merge

Workflow run
Successfully merged: create mode 100644 label_studio/tasks/tests/test_api.py

@hlomzik hlomzik enabled auto-merge (squash) May 30, 2025 17:01
@hlomzik hlomzik merged commit e54c3e1 into develop May 30, 2025
43 checks passed
@robot-ci-heartex robot-ci-heartex deleted the fb-bros-38/sentry-issues branch May 30, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants