-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix: BROS-38: Fix sentry issue (i.map is not a function) +1 more #7662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fetch can return null and this case was not handled in comments sdk.
OutlinerTree can't process regions list and crashes the app. This happens when region list has groupping by label and there is a region with no label. Empty labels should be fixed properly later, but the case is rare and we are fixing app crash here.
Error when user tries to expand "No Label" group
✅ Deploy Preview for label-studio-docs-new-theme ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for label-studio-playground canceled.
|
✅ Deploy Preview for label-studio-storybook canceled.
|
✅ Deploy Preview for heartex-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
bmartel
approved these changes
May 30, 2025
/git merge
|
/git merge
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two sentry issues are fixed here:
Very often one with comments sdk. Fetch can return null and this case was not handled in comments sdk.
TypeError: i.map is not a function
Rare, but with app crash and easy to fix. OutlinerTree can't process regions list and crashes the app.
This happens when region list has groupping by label and there is a region with no label.
Empty labels should be fixed properly later, but the case is rare and we are fixing app crash here.
Cannot read properties of undefined (reading 'locked')