Skip to content

Commit 4a4a409

Browse files
committed
fix: revert registerHandler to void return and add createHandler
fixes the method signature being incorrect and breaking backward compatability
1 parent fea9629 commit 4a4a409

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

src/main/java/net/hypixel/modapi/HypixelModAPI.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ private void registerEventPackets() {
7373
}
7474

7575
private void registerDefaultHandler() {
76-
registerHandler(ClientboundHelloPacket.class, p -> sendRegisterPacket(true));
76+
createHandler(ClientboundHelloPacket.class, p -> sendRegisterPacket(true));
7777
}
7878

7979
private void sendRegisterPacket(boolean alwaysSendIfNotEmpty) {
@@ -151,7 +151,15 @@ public void setPacketSender(Predicate<HypixelPacket> packetSender) {
151151
this.packetSender = packetSender;
152152
}
153153

154-
public <T extends ClientboundHypixelPacket> RegisteredHandler<T> registerHandler(Class<T> packetClass, ClientboundPacketHandler<T> handler) {
154+
/**
155+
* @deprecated Use {@link #createHandler(Class, ClientboundPacketHandler)} instead
156+
*/
157+
@Deprecated
158+
public <T extends ClientboundHypixelPacket> void registerHandler(Class<T> packetClass, ClientboundPacketHandler<T> handler) {
159+
createHandler(packetClass, handler);
160+
}
161+
162+
public <T extends ClientboundHypixelPacket> RegisteredHandler<T> createHandler(Class<T> packetClass, ClientboundPacketHandler<T> handler) {
155163
if (packetClass == null) {
156164
throw new NullPointerException("packetClass cannot be null");
157165
}

0 commit comments

Comments
 (0)