Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error reporting by including optional error message #79

Merged
merged 1 commit into from
May 7, 2024
Merged

Improve error reporting by including optional error message #79

merged 1 commit into from
May 7, 2024

Conversation

IanDBird
Copy link
Collaborator

@IanDBird IanDBird commented May 7, 2024

This PR includes the following:

  • We now extract any response text included in a response that's associated with a HTTP failure
  • We now both log and include any error response text in the exception raised by the SDK
  • I added some additional error handling that I took from the OpenPass SDK, to ensure we catch all potential IOException's

@IanDBird IanDBird merged commit ff93ebf into main May 7, 2024
2 checks passed
@IanDBird IanDBird deleted the ian/improved-error-reporting branch May 7, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcaunt dcaunt dcaunt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanDBird @dcaunt