Skip to content

Commit 481d4a2

Browse files
committed
Reverse case sensitive change
1 parent 63788fc commit 481d4a2

File tree

5 files changed

+14
-11
lines changed

5 files changed

+14
-11
lines changed

src/UID2.Client/Site.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ internal class Site
1010
public Site(int id, IEnumerable<string> domainNames)
1111
{
1212
Id = id;
13-
_domainNames = new HashSet<string>(domainNames);
13+
_domainNames = new HashSet<string>(domainNames, StringComparer.OrdinalIgnoreCase);
1414
}
1515

1616
public int Id { get; }

test/UID2.Client.Test/BidstreamClientTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -340,7 +340,7 @@ private void TokenIsCstgDerivedTest(string domainOrAppName, TokenVersion tokenVe
340340
[InlineData("example.com", TokenVersion.V4)]
341341
[InlineData("example.org", TokenVersion.V4)]
342342
[InlineData("com.123.Game.App.android", TokenVersion.V4)]
343-
private void DomainOrAppNameCaseSensitiveAndCheckFailedTest(string domainOrAppName, TokenVersion tokenVersion)
343+
private void DomainOrAppNameCaseInSensitiveTest(string domainOrAppName, TokenVersion tokenVersion)
344344
{
345345
Refresh(KeySharingResponse(new[] { MASTER_KEY, SITE_KEY }));
346346

test/UID2.Client.Test/EncryptionTestsV2.cs

+4-3
Original file line numberDiff line numberDiff line change
@@ -61,15 +61,16 @@ public void TokenIsCstgDerivedTest(string domainOrAppName)
6161
[InlineData("example.Com")]
6262
[InlineData("Example.org")]
6363
[InlineData("com.123.game.App.android")]
64-
public void DomainOrAppNameCaseSensitiveAndCheckFailedTest(string domainOrAppName)
64+
public void DomainOrAppNameCaseInSensitiveTest(string domainOrAppName)
6565
{
6666
_client.RefreshJson(KeySharingResponse(new [] { MASTER_KEY, SITE_KEY }));
6767
var privacyBits = PrivacyBitsBuilder.Builder().WithClientSideGenerated(true).Build();
6868
string advertisingToken = _tokenBuilder.WithPrivacyBits(privacyBits).Build();
6969
var res = _client.Decrypt(advertisingToken, domainOrAppName);
7070
Assert.True(res.IsClientSideGenerated);
71-
Assert.False(res.Success);
72-
Assert.Equal(DecryptionStatus.DomainOrAppNameCheckFailed, res.Status);
71+
Assert.True(res.Success);
72+
Assert.Equal(DecryptionStatus.Success, res.Status);
73+
Assert.Equal(EXAMPLE_EMAIL_RAW_UID2_V2, res.Uid);
7374
}
7475

7576
[Theory]

test/UID2.Client.Test/EncryptionTestsV3.cs

+4-3
Original file line numberDiff line numberDiff line change
@@ -81,15 +81,16 @@ public void TokenIsCstgDerivedTest(string domainOrAppName)
8181
[InlineData("example.Com")]
8282
[InlineData("Example.org")]
8383
[InlineData("com.123.game.App.android")]
84-
public void DomainOrAppNameCaseSensitiveAndCheckFailedTest(string domainOrAppName)
84+
public void DomainOrAppNameCaseInSensitiveTest(string domainOrAppName)
8585
{
8686
_client.RefreshJson(KeySharingResponse(new [] { MASTER_KEY, SITE_KEY }));
8787
var privacyBits = PrivacyBitsBuilder.Builder().WithClientSideGenerated(true).Build();
8888
string advertisingToken = _tokenBuilder.WithPrivacyBits(privacyBits).Build();
8989
var res = _client.Decrypt(advertisingToken, domainOrAppName);
9090
Assert.True(res.IsClientSideGenerated);
91-
Assert.False(res.Success);
92-
Assert.Equal(DecryptionStatus.DomainOrAppNameCheckFailed, res.Status);
91+
Assert.True(res.Success);
92+
Assert.Equal(DecryptionStatus.Success, res.Status);
93+
Assert.Equal(EXAMPLE_EMAIL_RAW_UID2_V2, res.Uid);
9394
}
9495

9596
[Theory]

test/UID2.Client.Test/EncryptionTestsV4.cs

+4-3
Original file line numberDiff line numberDiff line change
@@ -212,16 +212,17 @@ public void TokenIsCstgDerivedTest(string domainOrAppName)
212212
[InlineData("example.Com")]
213213
[InlineData("Example.org")]
214214
[InlineData("com.123.game.App.android")]
215-
public void DomainOrAppNameCaseSensitiveAndCheckFailedTest(string domainOrAppName)
215+
public void DomainOrAppNameCaseInSensitiveTest(string domainOrAppName)
216216
{
217217
_client.RefreshJson(KeySharingResponse(new [] { MASTER_KEY, SITE_KEY }));
218218
var privacyBits = PrivacyBitsBuilder.Builder().WithClientSideGenerated(true).Build();
219219
string advertisingToken = _tokenBuilder.WithPrivacyBits(privacyBits).Build();
220220
ValidateAdvertisingToken(advertisingToken, IdentityScope.UID2, IdentityType.Email);
221221
var res = _client.Decrypt(advertisingToken, domainOrAppName);
222222
Assert.True(res.IsClientSideGenerated);
223-
Assert.False(res.Success);
224-
Assert.Equal(DecryptionStatus.DomainOrAppNameCheckFailed, res.Status);
223+
Assert.True(res.Success);
224+
Assert.Equal(DecryptionStatus.Success, res.Status);
225+
Assert.Equal(EXAMPLE_EMAIL_RAW_UID2_V2, res.Uid);
225226
}
226227

227228
[Theory]

0 commit comments

Comments
 (0)